[ADD] l10n_latam_invoice_document_ux: Add new module to handle duplication of errors

Author: hav-adhoc

l10n_latam_invoice_document_ux/__init__.py

@@ -0,0 +1 @@
+from . import models

l10n_latam_invoice_document_ux/models/__init__.py

@@ -0,0 +1 @@
+from . import account_move

l10n_latam_invoice_document_ux/models/account_move.py

@@ -0,0 +1,27 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from odoo import models
+
+
+class AccountMove(models.Model):
+    _inherit = "account.move"
+
+    def _post(self, soft=True):
+        """Override to validate document number format before posting.
+        This ensures format errors are shown first, preventing duplicate error messages.
+        Only applies to vendor bills."""
+        # Validate document number format before posting (only for vendor bills)
+        vendor_bills = self.filtered(
+            lambda x: (
+                x.l10n_latam_use_documents
+                and x.l10n_latam_manual_document_number
+                and x.move_type in ("in_invoice", "in_refund")
+            )
+        )
+        for rec in vendor_bills:
+            if rec.l10n_latam_document_number and rec.l10n_latam_document_type_id:
+                if not rec._skip_format_document_number():
+                    # This will raise UserError if format is invalid
+                    # We let it propagate so the user sees the original format error
+                    rec.l10n_latam_document_type_id._format_document_number(rec.l10n_latam_document_number)
+        return super()._post(soft)

l10n_latam_invoice_document_ux/tests/test_patch_l10n_ar.py

@@ -13,46 +13,6 @@ def test_dummy(self):
 if tools.config.get("test_enable"):
     from odoo.addons.l10n_ar.tests.test_manual import TestArManual
 
-    def test_15_liquido_producto_sales_patch(self):
-        """Patcheamos para que la validacion se haga al momento de validar la factura y no antes"""
-
-        # Verify that the default sales journals ara created as is ARCA POS
-        self.assertTrue(self.journal.l10n_ar_is_pos)
-
-        # If we create an invoice it will not use manual numbering
-        invoice = self._create_invoice_ar()
-        self.assertFalse(invoice.l10n_latam_manual_document_number)
-
-        # Create a new sale journal that is not ARCA POS
-        self.journal = self._create_journal("preprinted", data={"l10n_ar_is_pos": False})
-        self.assertFalse(self.journal.l10n_ar_is_pos)
-
-        doc_27_lu_a = self.env.ref("l10n_ar.dc_liq_uci_a")
-        payment_term_id = self.env.ref("account.account_payment_term_end_following_month")
-
-        # 60, 61, 27, 28, 45, 46
-        # In this case manual numbering should be True and the latam document numer should be required
-        with self.assertRaisesRegex(AssertionError, "l10n_latam_document_number is a required field"):
-            with Form(self.env["account.move"].with_context(default_move_type="out_invoice")) as invoice_form:
-                invoice_form.ref = "demo_liquido_producto_1: Vendor bill liquido producto (DOC 186)"
-                invoice_form.partner_id = self.res_partner_adhoc
-                invoice_form.invoice_payment_term_id = payment_term_id
-                invoice_form.journal_id = self.journal
-                invoice_form.l10n_latam_document_type_id = doc_27_lu_a
-            invoice = invoice_form.save()
-            invoice.action_post()  # Agregamos esta linea para que se dispare la validacion al momento de validar la factura y no antes
-
-        # Adding the document number will let us to save and validate the number without any problems
-        with Form(self.env["account.move"].with_context(default_move_type="out_invoice")) as invoice_form:
-            invoice_form.ref = "demo_liquido_producto_1: Vendor bill liquido producto (DOC 186)"
-            invoice_form.partner_id = self.res_partner_adhoc
-            invoice_form.invoice_payment_term_id = payment_term_id
-            invoice_form.journal_id = self.journal
-            invoice_form.l10n_latam_document_type_id = doc_27_lu_a
-            invoice_form.l10n_latam_document_number = "00077-00000077"
-        invoice = invoice_form.save()
-        invoice.action_post()
-
     def test_16_liquido_producto_purchase_patch(self):
         """Patcheamos para que la validacion se haga al momento de validar la factura y no antes"""
 
@@ -69,17 +29,23 @@ def test_16_liquido_producto_purchase_patch(self):
         doc_60_lp_a = self.env.ref("l10n_ar.dc_a_cvl")
         payment_term_id = self.env.ref("account.account_payment_term_end_following_month")
 
-        with self.assertRaisesRegex(AssertionError, "l10n_latam_document_number is a required field"):
-            with Form(self.env["account.move"].with_context(default_move_type="in_invoice")) as bill_form:
-                bill_form.ref = "demo_liquido_producto_1: Vendor bill liquido producto (DOC 186)"
-                bill_form.partner_id = self.res_partner_adhoc
-                bill_form.invoice_payment_term_id = payment_term_id
-                bill_form.invoice_date = "2023-02-09"
-                bill_form.l10n_latam_document_type_id = doc_60_lp_a
-            bill = bill_form.save()
-            bill.action_post()  # Agregamos esta linea para que se dispare la validacion al momento de validar la factura y no antes
+        with Form(self.env["account.move"].with_context(default_move_type="in_invoice")) as bill_form:
+            bill_form.ref = "demo_liquido_producto_1: Vendor bill liquido producto (DOC 186)"
+            bill_form.partner_id = self.res_partner_adhoc
+            bill_form.invoice_payment_term_id = payment_term_id
+            bill_form.invoice_date = "2023-02-09"
+            bill_form.l10n_latam_document_type_id = doc_60_lp_a
+            with bill_form.invoice_line_ids.new() as line_form:
+                line_form.product_id = self.env.ref("product.product_product_4")
+                line_form.quantity = 1
+                line_form.price_unit = 100
+        bill = bill_form.save()
 
-            self.assertEqual(bill.journal_id, purchase_not_pos_journal)
+        self.assertEqual(bill.journal_id, purchase_not_pos_journal)
+
+        # Should fail when posting without document number
+        with self.assertRaisesRegex(AssertionError, "l10n_latam_document_number is a required field"):
+            bill.action_post()
 
         # Create a new journal that is an ARCA POS
         purchase_pos_journal = self._create_journal("preprinted", data={"type": "purchase", "l10n_ar_is_pos": True})
@@ -92,6 +58,10 @@ def test_16_liquido_producto_purchase_patch(self):
             bill_form.journal_id = purchase_pos_journal
             bill_form.l10n_latam_document_type_id = doc_60_lp_a
             bill_form.l10n_latam_document_number = "00077-00000077"
+            with bill_form.invoice_line_ids.new() as line_form:
+                line_form.product_id = self.env.ref("product.product_product_4")
+                line_form.quantity = 1
+                line_form.price_unit = 100
         bill = bill_form.save()
         bill.action_post()
 
@@ -112,11 +82,6 @@ def _patch_method(cls, name, method):
         wrapped.origin = origin
         setattr(cls, name, wrapped)
 
-    _patch_method(
-        TestArManual,
-        "test_15_liquido_producto_sales",
-        test_15_liquido_producto_sales_patch,
-    )
     _patch_method(
         TestArManual,
         "test_16_liquido_producto_purchase",