[FIX] l10n_ar_stock_ux: fix + minor improvements

1. arreglamos el if de calculo de barcode
2. pasamos a depender de declared value. Lo definimos así porque:
a) si bien no es obligatorio el dato, por uso y costumbre se usa un montón
b) además que si no para mandar un valor a COT deberíamos hacer un chino
c) eventualmente el declared value podría estar como campo en stock_ux y todo el cálculo automático en módulo separado (y extra?)

Author: jjscarafia

l10n_ar_stock_delivery/views/report_deliveryslip.xml

@@ -3,9 +3,9 @@
     <template id="report_delivery_document" inherit_id="l10n_ar_stock_ux.report_delivery_document">
 
         <t name="number_of_packages" position="after">
-            <span t-if="o._fields.get('number_of_packages') and o.number_of_packages and o.weight"> - </span>
+            <span t-if="o.number_of_packages and o.weight"> - </span>
             <t t-if="o.weight">
-                <br t-if="o._fields.get('number_of_packages') and not o.number_of_packages"/><strong>Weight:</strong>
+                <br t-if="not o.number_of_packages"/><strong>Weight:</strong>
                 <span t-field="o.weight"/>
                 <span t-field="o.weight_uom_name"/>
             </t>

l10n_ar_stock_ux/__manifest__.py

@@ -10,6 +10,12 @@
         "l10n_ar_stock",
         "l10n_ar_ux",
         "stock_picking_invoice_link",
+        "stock_ux",
+        # esta dependencia es solo por el campo declared value para:
+        # a) reporte de remito
+        # b) mandar valor declarado a wizard de COT
+        # eventualmente se podría moer dicho campo a stock_ux y evitar esta dependencia
+        "stock_declared_value",
     ],
     "data": [
         "security/res_groups.xml",

l10n_ar_stock_ux/models/stock_picking.py

@@ -1,6 +1,5 @@
 import datetime
 import logging
-import re
 import xml.etree.ElementTree as ET
 
 import requests
@@ -86,19 +85,16 @@ def _compute_l10n_ar_afip_barcode(self):
         for rec in self:
             barcode = False
             if (
-                rec.picking_type_id.l10n_ar_sequence_id.prefix and rec.l10n_ar_cai_data["cai_expiration_date"]
-                if rec.l10n_ar_cai_data
-                else rec.picking_type_id.l10n_ar_cai_expiration_date and rec.l10n_ar_cai_data["cai_authorization_code"]
-                if rec.l10n_ar_cai_data
-                else rec.picking_type_id.l10n_ar_cai_authorization_code
-                # TODO REVISAR
-                # and not rec.picking_type_id.lines_per_voucher
+                rec.l10n_ar_delivery_guide_number
+                and rec.document_type_id
+                and rec.l10n_ar_cai_data
+                and "cai_expiration_date" in rec.l10n_ar_cai_data
+                and "cai_authorization_code" in rec.l10n_ar_cai_data
             ):
                 cae_due = rec.l10n_ar_cai_data["cai_expiration_date"].strftime("%Y%m%d")
                 pos_number = self.env["account.move"]._l10n_ar_get_document_number_parts(
                     rec.l10n_ar_delivery_guide_number, rec.document_type_id.code
                 )["point_of_sale"]
-                pos_number = int(re.sub("[^0-9]", "", rec.picking_type_id.l10n_ar_sequence_id.prefix))
                 barcode = "".join(
                     [
                         str(rec.picking_type_id.report_partner_id.l10n_ar_vat or rec.company_id.partner_id.l10n_ar_vat),

l10n_ar_stock_ux/views/report_deliveryslip.xml

@@ -172,12 +172,12 @@
                     <strong>Customer Reference:</strong>
                     <span t-field="o.sudo().sale_id.client_order_ref"/>
                 </t>
-                <t t-if="o._fields.get('declared_value') and o.declared_value">
+                <t t-if="o.declared_value">
                     <br/>
                     <strong>Declared Value:</strong>
                     <span t-field="o.declared_value"/>
                 </t>
-                <t name="number_of_packages" t-if="o._fields.get('number_of_packages') and o.number_of_packages">
+                <t name="number_of_packages" t-if="o.number_of_packages">
                     <br/>
                     <strong>Packages Qty:</strong>
                     <span t-field="o.number_of_packages"/>

l10n_ar_stock_ux/views/stock_picking_views.xml

@@ -37,8 +37,9 @@
                 <attribute name="invisible">True</attribute>
             </button>
             <button name="do_print_picking" position="after">
-                <button name="%(action_arba_cot_wizard)d" string="Obtener COT (BETA)"
+                <button name="%(action_arba_cot_wizard)d" string="Obtener COT"
                     help="Obtener Código de Operaciones de Traslado (ARBA / Santa Fe)"
+                    context="{'default_importe': declared_value}"
                     type="action"
                     invisible="not l10n_ar_allow_send_delivery_guide or picking_type_code == 'incoming' or state != 'done' or cot"
                     groups="l10n_ar_stock_ux.arba_cot_enabled"/>

l10n_ar_stock_ux/wizards/arba_cot_wizard.py

@@ -36,7 +36,6 @@ class ArbaCotWizard(models.TransientModel):
         default="0",
         required=True,
     )
-    # TODO implementar asistente de importe
     importe = fields.Float(
         string="Importe Neto",
     )