[MIG] l10n_ar_sale: Migration to 19.0

Author: migration-bot-adhoc

l10n_ar_sale/__manifest__.py

@@ -1,6 +1,6 @@
 {
     "name": "Argentinian Sale Total Fields",
-    "version": "18.0.1.7.0",
+    "version": "19.0.1.0.0",
     "category": "Localization/Argentina",
     "sequence": 14,
     "author": "ADHOC SA",
@@ -20,7 +20,7 @@
         "wizards/res_config_settings_view.xml",
     ],
     "demo": [],
-    "installable": False,
+    "installable": True,
     "auto_install": False,
     "application": False,
 }

l10n_ar_sale/models/sale_order.py

@@ -38,7 +38,7 @@ def _compute_tax_totals(self):
             return
 
         for order in self.filtered(lambda x: not x.vat_discriminated):
-            tax_groups = order.order_line.mapped("tax_id.tax_group_id")
+            tax_groups = order.order_line.mapped("tax_ids.tax_group_id")
             if not tax_groups:
                 continue
             to_remove_ids = tax_groups.filtered(lambda x: x.l10n_ar_vat_afip_code).ids
@@ -110,10 +110,10 @@ def _l10n_ar_recompute_fiscal_position_taxes(self):
             date = fields.Date.to_date(fields.Datetime.context_timestamp(rec, rec.date_order))
             new_taxes = rec.fiscal_position_id._l10n_ar_add_taxes(rec.partner_id, rec.company_id, date, "perception")
             for line in rec.order_line:
-                to_unlink = line.tax_id.filtered(lambda x: x.tax_group_id in fp_tax_groups)
+                to_unlink = line.tax_ids.filtered(lambda x: x.tax_group_id in fp_tax_groups)
                 if to_unlink._origin != new_taxes:
-                    line.tax_id = [(3, tax.id) for tax in to_unlink] + [
-                        (4, tax.id) for tax in new_taxes if tax not in line.tax_id
+                    line.tax_ids = [(3, tax.id) for tax in to_unlink] + [
+                        (4, tax.id) for tax in new_taxes if tax not in line.tax_ids
                     ]
 
     def copy(self, default=None):

l10n_ar_sale/models/sale_order_line.py

@@ -44,11 +44,11 @@ def _compute_report_price_reduce(self):
             line.report_price_reduce = price_type / line.product_uom_qty if line.product_uom_qty else 0.0
 
     @api.depends(
-        "tax_id.tax_group_id.l10n_ar_vat_afip_code",
+        "tax_ids.tax_group_id.l10n_ar_vat_afip_code",
     )
     def _compute_vat_tax_id(self):
         for rec in self:
-            vat_tax_id = rec.tax_id.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
+            vat_tax_id = rec.tax_ids.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
             if len(vat_tax_id) > 1:
                 raise UserError(_("Only one vat tax allowed per line"))
             rec.vat_tax_id = vat_tax_id
@@ -59,17 +59,17 @@ def _compute_report_prices_and_taxes(self):
             order = line.order_id
             taxes_included = not order.vat_discriminated
             price_digits = 10 ** self.env["decimal.precision"].precision_get("Product Price")
-            price_unit = line.tax_id.compute_all(
+            price_unit = line.tax_ids.compute_all(
                 line.price_unit * price_digits, order.currency_id, 1.0, line.product_id, order.partner_shipping_id
             )
             if not taxes_included:
                 report_price_unit = price_unit["total_excluded"] / price_digits
                 report_price_subtotal = line.price_subtotal
-                not_included_taxes = line.tax_id
+                not_included_taxes = line.tax_ids
                 report_price_net = report_price_unit * (1 - (line.discount or 0.0) / 100.0)
             else:
-                included_taxes = line.tax_id.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
-                not_included_taxes = line.tax_id - included_taxes
+                included_taxes = line.tax_ids.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
+                not_included_taxes = line.tax_ids - included_taxes
                 report_price_unit = (
                     included_taxes.compute_all(
                         line.price_unit * price_digits,
@@ -112,9 +112,8 @@ def check_vat_tax(self):
             and x.company_id.country_id == self.env.ref("base.ar")
             and x.company_id.l10n_ar_company_requires_vat
             and x.product_type in ["consu", "service"]
-            and x.product_type != "combo"
         ):
-            vat_taxes = rec.tax_id.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
+            vat_taxes = rec.tax_ids.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)
             if len(vat_taxes) != 1:
                 raise UserError(
                     _(
@@ -128,18 +127,18 @@ def check_vat_tax(self):
     def write(self, vals):
         res = super(SaleOrderLine, self).write(vals)
         # for performance we only check if tax or company is on vals
-        if "tax_id" in vals or "company_id" in vals:
+        if "tax_ids" in vals or "company_id" in vals:
             self.check_vat_tax()
         return res
 
-    def _compute_tax_id(self):
+    def _compute_tax_ids(self):
         """Agregado de taxes de modulo l10n_ar_tax segun fiscal position"""
-        super()._compute_tax_id()
+        super()._compute_tax_ids()
 
         for rec in self.with_context(tz="America/Argentina/Buenos_Aires").filtered(
             "order_id.fiscal_position_id.l10n_ar_tax_ids"
         ):
             date = fields.Date.to_date(fields.Datetime.context_timestamp(rec, rec.order_id.date_order))
-            rec.tax_id += rec.order_id.fiscal_position_id._l10n_ar_add_taxes(
+            rec.tax_ids += rec.order_id.fiscal_position_id._l10n_ar_add_taxes(
                 rec.order_partner_id, rec.company_id, date, "perception"
             )

l10n_ar_sale/security/invoice_sale_security.xml

@@ -3,7 +3,6 @@
 
     <record id="sale_price_unit_with_tax" model="res.groups">
         <field name="name">Sale Unit Prices w/ Taxes</field>
-        <field name="category_id" ref="base.module_category_hidden"/>
     </record>
 
 </odoo>

l10n_ar_sale/views/l10n_ar_sale_templates.xml

@@ -1,18 +1,14 @@
 <odoo>
     <template id="sale_order_portal_content" inherit_id="sale.sale_order_portal_content" name="Sales Order">
 
-        <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" position="attributes">
-            <attribute name="t-value">current_subtotal + line.report_price_subtotal</attribute>
-        </t>
-
         <xpath expr="//div[@t-field='line.price_unit']" position="attributes">
             <attribute name="t-field">line.report_price_unit</attribute>
         </xpath>
         <xpath expr="//span[@t-field='line.price_subtotal']" position="attributes">
             <attribute name="t-field">line.report_price_subtotal</attribute>
         </xpath>
 
-        <xpath expr="//span[contains(@t-out, 'line.tax_id')]" position="attributes">
+        <xpath expr="//span[contains(@t-out, 'line.tax_ids')]" position="attributes">
             <attribute name="t-out">', '.join(map(lambda x: (x.invoice_label or x.name), line.report_tax_id))</attribute>
         </xpath>
 
@@ -25,7 +21,7 @@
         <!-- use column vat instead of taxes and only list vat taxes-->
         <td t-attf-class="text-end {{ 'd-none d-md-table-cell' if report_type == 'html' else '' }}" position="replace">
             <td id="taxes" t-if="sale_order.vat_discriminated" t-attf-class="text-right {{ 'd-none d-md-table-cell' if report_type == 'html' else '' }}">
-                <span t-out="', '.join(map(lambda x: (x.invoice_label or x.name), line.tax_id.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)))"/>
+                <span t-out="', '.join(map(lambda x: (x.invoice_label or x.name), line.tax_ids.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)))"/>
             </td>
         </td>
 

l10n_ar_sale/views/sale_report_templates.xml

@@ -62,24 +62,25 @@
             <attribute name="t-value">', '.join([(tax.invoice_label or tax.name) for tax in line.report_tax_id])</attribute>
         </t>
 
-        <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" position="attributes">
+        <!-- NOTE: current_subtotal element no longer exists in Odoo 19.0, so we remove this inheritance -->
+        <!-- <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" position="attributes">
             <attribute name="t-value">current_subtotal + line.report_price_subtotal</attribute>
-        </t>
+        </t> -->
 
         <span t-field="line.price_subtotal" position="attributes">
             <attribute name="t-field">line.report_price_subtotal</attribute>
         </span>
 
         <!-- use column vat instead of taxes and only if vat discriminated -->
         <th name="th_taxes" position="replace">
-            <th t-if="doc.vat_discriminated" name="th_taxes" t-attf-class="text-left {{ 'd-md-table-cell' if report_type == 'html' else '' }}"><span>% VAT</span></th>
+            <th t-if="doc.vat_discriminated" name="th_taxes" t-attf-class="text-end {{ 'd-md-table-cell' if report_type == 'html' else '' }}"><span>% VAT</span></th>
         </th>
         <!-- use column vat instead of taxes and only list vat taxes-->
-        <td name="td_taxes" position="attributes">
+        <td name="td_product_taxes" position="attributes">
             <attribute name="t-if">doc.vat_discriminated</attribute>
         </td>
         <t t-set="taxes" position="attributes">
-            <attribute name="t-value">', '.join([(tax.invoice_label or tax.name) for tax in line.tax_id.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)])</attribute>
+            <attribute name="t-value">', '.join([(tax.invoice_label or tax.name) for tax in line.tax_ids.filtered(lambda x: x.tax_group_id.l10n_ar_vat_afip_code)])</attribute>
         </t>
 
         <!-- We change the name of the column depending on the tax discrimination -->

l10n_ar_sale/views/sale_view.xml

@@ -8,13 +8,11 @@
             <group name="sale_info">
                 <field name="vat_discriminated"/>
             </group>
-            <xpath expr="//field[@name='order_line']/list//field[@name='tax_id']" position="after">
+            <xpath expr="//field[@name='order_line']/list//field[@name='tax_ids']" position="after">
                 <field name="price_unit_with_tax" groups="l10n_ar_sale.sale_price_unit_with_tax" widget="monetary"/>
-                <!-- <field name="currency_id" invisible="1"/> -->
             </xpath>
-            <xpath expr="//field[@name='order_line']/form//field[@name='tax_id']" position="after">
+            <xpath expr="//field[@name='order_line']/form//field[@name='tax_ids']" position="after">
                 <field name="price_unit_with_tax" groups="l10n_ar_sale.sale_price_unit_with_tax" widget="monetary"/>
-                <!-- <field name="currency_id" invisible="1"/> -->
             </xpath>
         </field>
     </record>