[FIX] price_security: restrict global discount and fixed amount

X-original-commit: 2963aaa

Author: lef-adhoc

price_security/__init__.py

@@ -3,3 +3,4 @@
 # directory
 ##############################################################################
 from . import models
+from . import wizard

price_security/__manifest__.py

@@ -19,7 +19,7 @@
 ##############################################################################
 {
     "name": "Price Security",
-    "version": "18.0.1.1.0",
+    "version": "18.0.1.2.0",
     "category": "Sales Management",
     "author": "ADHOC SA, Odoo Community Association (OCA)",
     "website": "http://www.adhoc.com.ar/",
@@ -32,6 +32,7 @@
     "data": [
         "security/price_security_security.xml",
         "security/ir.model.access.csv",
+        "wizard/sale_order_discount_views.xml",
         "views/account_move_views.xml",
         "views/account_payment_term_views.xml",
         "views/product_template_views.xml",

price_security/i18n/es.po

@@ -214,3 +214,12 @@ msgstr ""
 #: code:addons/price_security/models/res_users.py:0
 msgid "You can not give any discount greater than pricelist discounts"
 msgstr ""
+
+#. module: price_security
+#. odoo-python
+#: code:addons/price_security/wizard/sale_order_discount.py:0
+#, python-format
+msgid ""
+"You do not have permission to apply this type of discount with the current "
+"pricelist."
+msgstr "No tienes permiso para aplicar este tipo de descuento con la lista de precios actual."

price_security/wizard/__init__.py

@@ -0,0 +1 @@
+from . import sale_order_discount

price_security/wizard/sale_order_discount.py

@@ -0,0 +1,30 @@
+from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
+
+
+class SaleOrderDiscount(models.TransientModel):
+    _inherit = "sale.order.discount"
+
+    discount_restriction = fields.Boolean(compute="_compute_discount_restriction")
+
+    @api.depends("discount_type")
+    def _compute_discount_restriction(self):
+        restricted_types = {"amount", "so_discount"}
+        user = self.env.user
+
+        for wizard in self:
+            if (
+                wizard.discount_type in restricted_types
+                and user.has_group("price_security.group_only_view")
+                and wizard.sale_order_id.pricelist_id in user.discount_restriction_ids.mapped("pricelist_id")
+            ):
+                wizard.discount_restriction = True
+            else:
+                wizard.discount_restriction = False
+
+    @api.constrains("discount_type")
+    def _check_discount_type(self):
+        if self.filtered("discount_restriction"):
+            raise ValidationError(
+                _("You do not have permission to apply this type of discount " "with the current pricelist.")
+            )

price_security/wizard/sale_order_discount_views.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+    <record id="sale_order_line_wizard_form" model="ir.ui.view">
+        <field name="name">sale.order.line.wizard.form</field>
+        <field name="model">sale.order.discount</field>
+        <field name="inherit_id" ref="sale.sale_order_line_wizard_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//sheet" position="before">
+                <div class="alert alert-warning" role="alert" invisible="not discount_restriction">
+                  Advertencia: No tienes permiso para aplicar este tipo de descuento con la lista de precios actual.
+                </div>
+            </xpath>
+        </field>
+    </record>
+</odoo>