[MIG] price_security_sale_margin: Migration to 19.0

Author: migration-bot-adhoc

price_security_sale_margin/__manifest__.py

@@ -19,7 +19,7 @@
 ##############################################################################
 {
     "name": "Price Security with sale margin",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "category": "Sales Management",
     "author": "ADHOC SA",
     "website": "http://www.adhoc.com.ar/",
@@ -28,6 +28,6 @@
         "price_security",
         "sale_margin",
     ],
-    "installable": False,
+    "installable": True,
     "auto_install": True,
 }

price_security_sale_margin/models/sale_order.py

@@ -22,15 +22,16 @@ def _get_view(self, view_id=None, view_type="form", **options):
                     modifiers["readonly"] = True
                     node.set("modifiers", json.dumps(modifiers))
             if self.env.user.has_group("price_security.group_only_view_sale_price"):
-                invisible_fields = (
-                    arch.xpath("//field[@name='purchase_price']")
-                    + arch.xpath("//field[@name='margin']")
-                    + arch.xpath("//field[@name='margin_percent']")
-                    + arch.xpath("//field[@name='margin_percent']/..")
+                invisible_fields = arch.xpath(
+                    "//field[@name='purchase_price']"
+                    "|//field[@name='order_line']//field[@name='margin']"
+                    "|//field[@name='order_line']//field[@name='margin_percent']"
+                    "|//div[@class='d-flex float-end']"
                 )
                 for node in invisible_fields:
+                    node.set("invisible", "1")
                     node.set("column_invisible", "1")
                     modifiers = json.loads(node.get("modifiers") or "{}")
-                    modifiers["column_invisible"] = True
+                    modifiers["invisible"] = True
                     node.set("modifiers", json.dumps(modifiers))
         return arch, view