[FIX] sale_three_discounts: ensure proper handling of discount field during record creation and updates

closes #1461

Signed-off-by: matiasperalta1 <mnp@adhoc.com.ar>

Author: lef-adhoc

sale_three_discounts/__manifest__.py

@@ -19,7 +19,7 @@
 ##############################################################################
 {
     "name": "Sale Three Discounts",
-    "version": "18.0.1.3.0",
+    "version": "18.0.1.4.0",
     "category": "Sales Management",
     "sequence": 14,
     "author": "ADHOC SA",

sale_three_discounts/models/account_move_line.py

@@ -29,8 +29,26 @@ def check_discount_validity(self):
 
     @api.depends("discount1", "discount2", "discount3")
     def _compute_discount(self):
-        for line in self.filtered(lambda x: x.move_type not in ("in_invoice", "in_refund")):
+        for line in self:
             discount_factor = 1.0
             for discount in [line.discount1, line.discount2, line.discount3]:
                 discount_factor *= (100.0 - discount) / 100.0
             line.discount = 100.0 - (discount_factor * 100.0)
+
+    @api.model
+    def _get_multiple_discount_field_names(self):
+        return ["discount1", "discount2", "discount3"]
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            if vals.get("discount") and not any(vals.get(field) for field in self._get_multiple_discount_field_names()):
+                vals["discount1"] = vals.pop("discount")
+        return super().create(vals_list)
+
+    def write(self, vals):
+        discount_fields = self._get_multiple_discount_field_names()
+        if "discount" in vals:
+            vals["discount1"] = vals.pop("discount")
+            vals.update({field: 0 for field in discount_fields[1:]})
+        return super().write(vals)

sale_three_discounts/views/account_invoice_views.xml

@@ -6,14 +6,10 @@
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_move_form" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='invoice_line_ids']//list//field[@name='discount']" position="attributes">
-                <attribute name="readonly">parent.move_type in ('out_invoice', 'out_refund')</attribute>
-                <attribute name="force_save">1</attribute>
-            </xpath>
             <xpath expr="//field[@name='invoice_line_ids']//list//field[@name='discount']" position="before">
-                <field name="discount1" column_invisible="parent.move_type not in ('out_invoice', 'out_refund')" groups="sale.group_discount_per_so_line" />
-                <field name="discount2" column_invisible="parent.move_type not in ('out_invoice', 'out_refund')" groups="sale.group_discount_per_so_line" />
-                <field name="discount3" column_invisible="parent.move_type not in ('out_invoice', 'out_refund')" groups="sale.group_discount_per_so_line" />
+                <field name="discount1" groups="sale.group_discount_per_so_line" />
+                <field name="discount2" groups="sale.group_discount_per_so_line" />
+                <field name="discount3" groups="sale.group_discount_per_so_line" />
             </xpath>
             <xpath expr="//field[@name='line_ids']//list//field[@name='discount_amount_currency']" position="before">
                 <field name="discount1" column_invisible="True" />