Skip to content

Commit 55347f5

Browse files
committed
[FIX]stock_voucher: calculate package number correctly
closes #850 Signed-off-by: Juan Carreras <jc@adhoc.com.ar>
1 parent a0ab091 commit 55347f5

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

stock_voucher/models/stock_picking.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@ def do_stock_voucher_transfer_check(self):
110110
"""
111111
We separe to use it in other modules
112112
"""
113+
if self.picking_type_id.number_of_packages:
114+
packages = self.move_line_ids.mapped("result_package_id").filtered(lambda p: p)
115+
self.number_of_packages = len(packages)
113116
for picking in self:
114117
if picking.picking_type_id.code == "outgoing":
115118
if picking.picking_type_id.restrict_number_package and not picking.number_of_packages > 0:
@@ -121,15 +124,6 @@ def do_stock_voucher_transfer_check(self):
121124
raise UserError(_("You must set stock voucher numbers"))
122125
return True
123126

124-
def action_put_in_pack(self, move_lines_to_pack=False):
125-
"""
126-
We override to compute number of packages
127-
"""
128-
res = super().action_put_in_pack(move_lines_to_pack=move_lines_to_pack)
129-
if self.picking_type_id.number_of_packages:
130-
self.number_of_packages = len(self.package_level_ids)
131-
return res
132-
133127
def button_validate(self):
134128
"""
135129
We make checks before calling transfer

0 commit comments

Comments
 (0)