Merge pull request #47 from ingenerator/4.x-bug-cache-race-condition

Fix race condition attempting to read cache files

Author: acoulton

CHANGELOG.md

@@ -2,6 +2,10 @@ You're really going to want to read this.
 
 ## Unreleased
 
+## 4.12.1 (2025-01-16)
+
+* Fix race condition attempting to read cache files causing error from `find_file`
+
 ## 4.12.0 (2024-09-24)
 
 * Support PHP 8.3

classes/Kohana/Core.php

@@ -281,8 +281,8 @@ public static function init(array $settings = NULL)
 
 		if (Kohana::$caching === TRUE)
 		{
-			// Load the file path cache
-			Kohana::$_files = Kohana::cache('Kohana::find_file()');
+			// Load the file path cache if present
+			Kohana::$_files = Kohana::cache('Kohana::find_file()') ?? [];
 		}
 
 		if (isset($settings['charset']))
@@ -902,7 +902,15 @@ public static function cache($name, $data = NULL, $lifetime = NULL)
 					// Return the cache
 					try
 					{
-						return \unserialize(\file_get_contents($dir.$file));
+						$content = \file_get_contents($dir.$file);
+						if ($content === FALSE)
+						{
+							// Cache has been removed since the `is_file` call above e.g. it is on the moment of expiry
+							// Treat as cache miss
+							return NULL;
+						}
+
+						return \unserialize($content);
 					}
 					catch (Exception $e)
 					{