Merge pull request #1 from ingenerator/php7.2-compatibility

Drop support for php5 and test on php7.2

Author: craig410

.gitignore

@@ -3,3 +3,4 @@
 /bin
 /koharness_bootstrap.php
 composer.lock
+/.idea

.travis.yml

@@ -1,12 +1,14 @@
 language: php
 
 php:
- - 5.5
- - 5.6
+  - 7.2
 
 before_script:
   - composer install --prefer-dist
   - bin/koharness
 
 script:
   - bin/phpspec run
+
+notifications:
+  email: false

CHANGELOG.md

@@ -4,7 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+## 1.0.0 / 2019-04-03
 * Drop support for PHP <=5.5
+* Ensure support on php7.2
 
 ## 0.1.1 / 2017-03-02
 

classes/Ingenerator/Pigeonhole/Message/KohanaMessage.php

@@ -59,11 +59,11 @@ protected function lookup_message($message_file, $path, $params)
 		$message = \Kohana::message($message_file, $path);
 
 		if ($message) {
-			return strtr($message, $params);
+			return \strtr($message, $params);
 		} else {
 			$full_path = $message_file.":".$path;
 			\Kohana::$log->add(\Log::WARNING, "Unknown message - ".$full_path);
-			return $full_path.' '.json_encode($params);
+			return $full_path.' '.\json_encode($params);
 		}
 	}
 } 

classes/Ingenerator/Pigeonhole/Message/ValidationMessage.php

@@ -30,7 +30,7 @@ class ValidationMessage extends Message {
 	public function __construct(\Validation $validation, $message_file, $title = 'Sorry, your request could not be processed', $class = Message::DANGER) {
 		$this->title = $title;
 		$this->class = $class;
-		$this->message = implode(PHP_EOL, $validation->errors($message_file));
+		$this->message = \implode(PHP_EOL, $validation->errors($message_file));
 	}
 
 } 

classes/Ingenerator/Pigeonhole/Pigeonhole.php

@@ -55,7 +55,7 @@ public function add(Message $message)
 	 */
 	public function has_messages()
     {
-		return (count($this->peek()) > 0);
+		return (\count($this->peek()) > 0);
     }
 
 	/**

composer.json

@@ -13,7 +13,7 @@
     }
   ],
   "require": {
-    "php":           ">=5.5",
+    "php":           "^7.2",
     "kohana/core":   "3.3.*"
   },
   "require-dev": {

spec/Ingenerator/Pigeonhole/View/Pigeonhole/MessagesSpec.php

@@ -71,8 +71,8 @@ protected function given_messages($pigeonhole, $msg)
 	{
 		$pigeonhole->has_messages()->willReturn(TRUE);
 
-		$messages = func_get_args();
-		array_shift($messages);
+		$messages = \func_get_args();
+		\array_shift($messages);
 		$pigeonhole->clear()->willReturn($messages);
 	}
 }