Skip to content

Commit 5b644cf

Browse files
fix: avoid loading artifact data in trace timeline (#1820) (#3376)
* fix: avoid loading artifact data in trace timeline * removed the inline artifact JSON viewer * readd JsonEditorWithCopy * remove those ok files GitOrigin-RevId: 355e7f5de276f7f9e6dbc1e6811b592a4b681383 Co-authored-by: robert-inkeep <123133375+robert-inkeep@users.noreply.github.com>
1 parent 1ba47aa commit 5b644cf

5 files changed

Lines changed: 19 additions & 16 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@inkeep/agents-manage-ui": patch
3+
---
4+
5+
Avoid loading artifact bodies in conversation traces

agents-manage-ui/src/app/api/traces/conversations/[conversationId]/route.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,6 @@ function buildAllSpansPayload(
417417
sf(SPAN_KEYS.ARTIFACT_TOOL_CALL_ID, str, attr),
418418
sf(SPAN_KEYS.ARTIFACT_NAME, str, attr),
419419
sf(SPAN_KEYS.ARTIFACT_DESCRIPTION, str, attr),
420-
sf(SPAN_KEYS.ARTIFACT_DATA, str, attr),
421420
sf(SPAN_KEYS.ARTIFACT_IS_OVERSIZED, bool, attr),
422421
sf(SPAN_KEYS.ARTIFACT_RETRIEVAL_BLOCKED, bool, attr),
423422
sf(SPAN_KEYS.ARTIFACT_ORIGINAL_TOKEN_SIZE, int64, attr),
@@ -909,7 +908,6 @@ export async function GET(
909908
artifactType?: string;
910909
artifactName?: string;
911910
artifactDescription?: string;
912-
artifactData?: string;
913911
artifactSubAgentId?: string;
914912
artifactToolCallId?: string;
915913
artifactIsOversized?: boolean;
@@ -1310,7 +1308,6 @@ export async function GET(
13101308
artifactType: artifactType || undefined,
13111309
artifactName: artifactName || undefined,
13121310
artifactDescription: artifactDescription || undefined,
1313-
artifactData: getString(span, SPAN_KEYS.ARTIFACT_DATA, '') || undefined,
13141311
artifactToolCallId: getString(span, SPAN_KEYS.ARTIFACT_TOOL_CALL_ID, '') || undefined,
13151312
artifactIsOversized: isOversized || undefined,
13161313
artifactRetrievalBlocked: retrievalBlocked || undefined,

agents-manage-ui/src/components/traces/timeline/render-panel-content.tsx

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
} from '@/components/traces/timeline/types';
2525
import { Badge } from '@/components/ui/badge';
2626
import { Button } from '@/components/ui/button';
27+
import { SPAN_KEYS } from '@/constants/signoz';
2728
import { formatDateTime } from '@/lib/utils/format-date';
2829
import { formatCostUsd, resolveCacheUsage, type SpanData } from '@/lib/utils/trace-usage';
2930

@@ -688,20 +689,29 @@ export function renderPanelContent({
688689
);
689690
}
690691

691-
case 'artifact_processing':
692+
case 'artifact_processing': {
693+
const artifactData =
694+
typeof span?.data?.[SPAN_KEYS.ARTIFACT_DATA] === 'string'
695+
? span.data[SPAN_KEYS.ARTIFACT_DATA]
696+
: undefined;
692697
return (
693698
<>
694699
<Section>
695700
{a.artifactName && <Info label="Name" value={a.artifactName} />}
696701
{a.artifactType && <Info label="Type" value={a.artifactType} />}
697702
{a.artifactDescription && <Info label="Description" value={a.artifactDescription} />}
698-
{a.artifactData && (
703+
{artifactData && (
699704
<JsonEditorWithCopy
700-
value={formatJsonSafely(a.artifactData)}
705+
value={formatJsonSafely(artifactData)}
701706
title="Artifact data"
702707
uri="artifact-data.json"
703708
/>
704709
)}
710+
{!artifactData && spanLoading && (
711+
<div className="text-xs text-muted-foreground animate-pulse">
712+
Loading artifact data…
713+
</div>
714+
)}
705715
<StatusBadge status={a.status} />
706716
{a.status === 'error' && a.otelStatusDescription && (
707717
<LabeledBlock label="Status message">
@@ -751,6 +761,7 @@ export function renderPanelContent({
751761
{AdvancedBlock}
752762
</>
753763
);
764+
}
754765

755766
case 'tool_approval_requested':
756767
return (

agents-manage-ui/src/components/traces/timeline/timeline-item.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -505,15 +505,6 @@ export function TimelineItem({
505505
</span>
506506
</div>
507507
)}
508-
{activity.artifactData && (
509-
<div className="mt-2">
510-
<JsonEditorWithCopy
511-
value={formatJsonSafely(activity.artifactData)}
512-
title="Artifact data"
513-
uri={`artifact-data-${activity.id}.json`}
514-
/>
515-
</div>
516-
)}
517508
</div>
518509
</div>
519510
</div>

agents-manage-ui/src/components/traces/timeline/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ export interface ActivityItem {
122122
artifactType?: string;
123123
artifactName?: string;
124124
artifactDescription?: string;
125-
artifactData?: string;
126125
artifactSubAgentId?: string;
127126
artifactToolCallId?: string;
128127
artifactIsOversized?: boolean;

0 commit comments

Comments
 (0)