Setting the --tcp flag to false, inletsctl still creates an exit-node in tcp mode

[jsiebens]

Setting the --tcp flag to false, inletsctl still creates an exit-node in tcp mode unless --letsencrypt-domain is also provided

Expected Behaviour

Created exit node is running in TCP mode.

Current Behaviour

Created exit node is running in HTTP mode.

Possible Solution

Two options:

• An exit node created with --tcp=false is running in HTTP mode
• When running --tcp=false, validate if --letsencrypt-domain is also set and return error if not

Steps to Reproduce (for bugs)

1. Create and exit node without the --letsencrypt-domain and with --tcp=false

$ inletsctl create --provider scaleway --secret-key <redacted> --organisation-id <redacted> --tcp=false
Using provider: scaleway
Requesting host: magical-grothendieck0 in fr-par-1, from scaleway
Host: 409fb4c0-f304-4f21-8549-440ddd0d77cf, status: stopped
[1/500] Host: 409fb4c0-f304-4f21-8549-440ddd0d77cf, status: starting
...
[11/500] Host: 409fb4c0-f304-4f21-8549-440ddd0d77cf, status: active
inlets Pro TCP (0.9.9) server summary:
  IP: 51.158.116.170
  Auth-token: vCB98KplpCwORSc4mnq0bTbwbqwjEZhuOXC8QvIGJSWnGhP0Ez0TUudWV8ZV8V9h

Command:

# Obtain a license at https://inlets.dev/pricing
# Store it at $HOME/.inlets/LICENSE or use --help for more options

# Give a single value or comma-separated
export PORTS="8000"

# Where to route traffic from the inlets server
export UPSTREAM="localhost"

inlets-pro tcp client --url "wss://51.158.116.170:8123" \
  --token "vCB98KplpCwORSc4mnq0bTbwbqwjEZhuOXC8QvIGJSWnGhP0Ez0TUudWV8ZV8V9h" \
  --upstream $UPSTREAM \
  --ports $PORTS

To delete:
  inletsctl delete --provider scaleway --id "409fb4c0-f304-4f21-8549-440ddd0d77cf"

Context

Your Environment

• inlets Pro version inlets-pro version

• inletsctl version inletsctl version 0.8.19

• Cloud provider and region being used

• Operating System and version (e.g. Linux, Windows, MacOS): uname -a

• Link to your project or a code example to reproduce issue:

[alexellis]

Is this still an issue and was it only with Scaleway? @jsiebens