switch over to use interfaces library to make life better (disneystreaming#1977)

* switch over to use interfaces library to make life better

* add additional modularity for testability

* bump smithy build version

* add mima exclusion

* address comments

Author: yisraelU

build.sbt

@@ -1,3 +1,4 @@
+import com.typesafe.tools.mima.core._
 import software.amazon.smithy.model.traits.TraitService
 import _root_.java.util.stream.Collectors
 import java.nio.file.Files
@@ -253,7 +254,15 @@ lazy val core = projectMatrix
     scalacOptions ++= Seq(
       "-Wconf:msg=value noInlineDocumentSupport in class ProtocolDefinition is deprecated:silent"
     ),
-    mimaBinaryIssueFilters ++= Seq.empty
+    // smithy-waiters 1.72.0 added a new `message` field to the `Acceptor` structure
+    // (see waiters.smithy upstream), which shifted the arity of the generated
+    // `smithy.waiters.Acceptor.apply` case class constructor. This is generated
+    // prelude code for the built-in waiters trait, not hand-authored API.
+    mimaBinaryIssueFilters ++= Seq(
+      ProblemFilters.exclude[DirectMissingMethodProblem](
+        "smithy.waiters.Acceptor.apply"
+      )
+    )
   )
   .jvmPlatform(allJvmScalaVersions, jvmDimSettings)
   .jsPlatform(allJsScalaVersions, jsDimSettings)
@@ -418,8 +427,7 @@ lazy val codegen = projectMatrix
       Dependencies.Circe.core.value,
       Dependencies.Circe.parser.value,
       Dependencies.Circe.generic.value,
-      ("io.get-coursier" %% "coursier" % "2.1.24")
-        .cross(CrossVersion.for3Use2_13),
+      Dependencies.CoursierInterface.core,
       Dependencies.Mima.core % Test
     ),
     libraryDependencies ++= {
@@ -430,18 +438,6 @@ lazy val codegen = projectMatrix
         )
       else Seq.empty
     },
-    // For Scala 3, exclude transitive Scala 2.13 deps from coursier that conflict with Scala 3 cross versions.
-    // Note: scala-xml_2.13 is NOT excluded because coursier needs it at runtime.
-    excludeDependencies ++= {
-      if (scalaVersion.value.startsWith("3."))
-        Seq(
-          ExclusionRule(
-            "org.scala-lang.modules",
-            "scala-collection-compat_2.13"
-          )
-        )
-      else Seq.empty
-    },
     libraryDependencies ++= munitDeps.value,
     scalacOptions := scalacOptions.value
       .filterNot(Seq("-Ywarn-value-discard", "-Wvalue-discard").contains) ++ {
@@ -523,18 +519,7 @@ lazy val codegenPlugin = (projectMatrix in file("modules/codegen-plugin"))
     List(Scala38),
     Seq.empty[VirtualAxis],
     (p: Project) =>
-      p.settings(
-        jvmDimSettings,
-        // When cross-building for Scala 3 / sbt 2, the codegen dependency brings in
-        // coursier with Scala 2.13 variants that conflict with Scala 3 variants.
-        excludeDependencies ++= Seq(
-          ExclusionRule(
-            "org.scala-lang.modules",
-            "scala-collection-compat_2.13"
-          ),
-          ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-        )
-      ).dependsOn(codegen.jvm(Scala3))
+      p.settings(jvmDimSettings).dependsOn(codegen.jvm(Scala3))
   )
   .settings(
     name := "sbt-codegen",

modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-open-enums/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-specs/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/cross-builds/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/custom-settings/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/dependencies-only/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/extra-configs/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}

modules/codegen-plugin/src/sbt-test/codegen-plugin/multimodule-aws/project/plugins.sbt

@@ -7,14 +7,3 @@ sys.props.get("plugin.version") match {
          |Specify this property using the scriptedLaunchOpts -D.""".stripMargin
     )
 }
-
-// When running under sbt 2 (Scala 3), exclude Scala 2.13 variants that
-// conflict with Scala 3 variants brought in transitively by coursier.
-excludeDependencies ++= {
-  if (scalaBinaryVersion.value == "3")
-    Seq(
-      ExclusionRule("org.scala-lang.modules", "scala-collection-compat_2.13"),
-      ExclusionRule("org.scala-lang.modules", "scala-xml_2.13")
-    )
-  else Seq.empty
-}