Chore maintenance (#54)

* Composer update
* Tested up to 6.9
* PCP issues addressed
* PHPCS configured
* Patch excluded from plugin check
* Unit test adjusted
* Packages updated

Author: lloc

.github/workflows/code-style.yml

@@ -9,4 +9,4 @@ jobs:
       - name: Composer dependencies
         run: composer install
       - name: Run Testsuite
-        run: composer run-script cs
+        run: composer run-script phpcs

.github/workflows/plugin-check.yml

@@ -17,4 +17,5 @@ jobs:
       - name: Run plugin check
         uses: wordpress/plugin-check-action@v1
         with:
-          build-dir: './multisyde'
+          build-dir: './multisyde'
+          exclude-files: 'modules/**/patches/*.php'

.phpcs.xml.dist

@@ -11,10 +11,15 @@
     <arg name="extensions" value="php"/>
     <arg name="cache" value=".phpcs.cache"/>
 
+	<rule ref="PHPCompatibilityWP" />
+
     <rule ref="WordPress">
         <!-- PSR4 -->
         <exclude name="WordPress.Files.FileName" />
     </rule>
     <rule ref="WordPress-Extra"/>
     <rule ref="WordPress-Docs"/>
+
+    <exclude-pattern>*/node_modules/*</exclude-pattern>
+    <exclude-pattern>*/vendor/*</exclude-pattern>
 </ruleset>

composer.json

@@ -35,7 +35,8 @@
     "config": {
         "allow-plugins": {
             "dealerdirect/phpcodesniffer-composer-installer": true,
-            "phpstan/extension-installer": true
+            "phpstan/extension-installer": true,
+            "lloc/composer-i18n-scripts": true
         }
     },
     "require-dev": {
@@ -44,19 +45,20 @@
         "phpstan/extension-installer": "^1.4",
         "phpunit/phpunit": "^9.6",
         "brain/monkey": "^2.0@dev",
-        "phpstan/phpstan-mockery": "^2.0"
+        "phpstan/phpstan-mockery": "^2.0",
+        "lloc/composer-i18n-scripts": "^1.0",
+        "phpcompatibility/phpcompatibility-wp": "^2.1"
     },
     "scripts": {
         "tests": "./vendor/bin/phpunit -c ./phpunit.xml.dist",
         "tests:coverage": "XDEBUG_MODE=coverage ./vendor/bin/phpunit -c ./phpunit.xml.dist --coverage-html ./tests/coverage",
-        "cs": "./vendor/bin/phpcs .",
-        "cs:fix": "./vendor/bin/phpcbf .",
+        "phpcs": "vendor/bin/phpcs .",
+        "phpcbf": "./vendor/bin/phpcbf .",
         "phpstan": "./vendor/bin/phpstan analyse --memory-limit=1G",
         "qa": [
             "@cs",
             "@phpstan"
         ],
-        "i18n:pot": "wp i18n make-pot . languages/multisyde.pot",
         "git-release": "bin/git-release.sh",
         "build": [
             "@composer install --no-dev",

modules/SiteActivePlugins/Feature.php

@@ -18,6 +18,7 @@ final class Feature implements LoadableFeature {
 	const NOTICE_DEACTIVATION = 'bulk_deactivated';
 
 	const DEFAULT_MAX_SITES = 100;
+	const FILTER_MAX_SITES  = 'multisyde_site_active_plugins_max_sites';
 
 	/**
 	 * The active plugins in the sites in the network.
@@ -161,7 +162,7 @@ public function populate_active_plugins(): void {
 		 *
 		 * @param int $max_sites The maximum number of sites to show for each plugin.
 		 */
-		$max_sites = apply_filters( 'site_active_plugins_max_sites', self::DEFAULT_MAX_SITES );
+		$max_sites = apply_filters( self::FILTER_MAX_SITES, self::DEFAULT_MAX_SITES );
 		$site_ids  = get_sites(
 			array(
 				'fields' => 'ids',

modules/SiteActivePlugins/tests/unit/TestFeature.php

@@ -202,7 +202,7 @@ public function test_populate_active_plugins_network_active(): void {
 	public function test_populate_active_plugins_max_sites(): void {
 		$max_sites = 5;
 
-		Filters\expectApplied( 'site_active_plugins_max_sites' )->once()->with( 100 )->andReturn( $max_sites );
+		Filters\expectApplied( Feature::FILTER_MAX_SITES )->once()->with( 100 )->andReturn( $max_sites );
 
 		$args = array(
 			'fields' => 'ids',