change Validator::validate return type (#797)

Author: Mr-Leshiy

rust/catalyst-contest/src/contest_ballot/tests.rs

@@ -80,16 +80,16 @@ fn contest_ballot(
     let mut validator = Validator::new();
     validator.extend_rules_per_document(doc_types::CONTEST_BALLOT.clone(), ContestBallotRule {});
 
-    let is_valid = validator.validate(&doc, &provider).unwrap();
+    validator.validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    let is_valid = !doc.report().is_problematic();
 
     // Generate similar `CatalystSignedDocument` instance to have a clean internal problem
     // report.
     let doc = doc_gen(&mut provider).unwrap();
     let contest_ballot = ContestBallot::new(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !contest_ballot.report().is_problematic());
     println!("{:?}", contest_ballot.report());
+    assert_eq!(is_valid, !contest_ballot.report().is_problematic());
 
     is_valid
 }

rust/catalyst-contest/src/contest_delegation/tests.rs

@@ -128,16 +128,16 @@ fn contest_delegation(
     validator
         .extend_rules_per_document(doc_types::CONTEST_DELEGATION.clone(), ContestDelegationRule);
 
-    let is_valid = validator.validate(&doc, &p).unwrap();
+    validator.validate(&doc, &p).unwrap();
     println!("{:?}", doc.report());
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    let is_valid = !doc.report().is_problematic();
 
     // Generate similar `CatalystSignedDocument` instance to have a clean internal problem
     // report
     let doc = doc_gen(&mut p).unwrap();
     let contest_delegation = ContestDelegation::new(&doc, &p).unwrap();
-    assert_eq!(is_valid, !contest_delegation.report().is_problematic());
     println!("{:?}", contest_delegation.report());
+    assert_eq!(is_valid, !contest_delegation.report().is_problematic());
 
     is_valid
 }

rust/catalyst-contest/src/contest_parameters/tests.rs

@@ -57,9 +57,9 @@ fn contest_parameters(
     validator
         .extend_rules_per_document(doc_types::CONTEST_PARAMETERS.clone(), ContestParametersRule);
 
-    let is_valid = validator.validate(&doc, &p).unwrap();
+    validator.validate(&doc, &p).unwrap();
     println!("{:?}", doc.report());
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    let is_valid = !doc.report().is_problematic();
 
     // Generate similar `CatalystSignedDocument` instance to have a clean internal problem
     // report

rust/signed_doc/src/validator/mod.rs

@@ -77,23 +77,22 @@ impl Validator {
     }
 
     /// A comprehensive document type based validation of the `CatalystSignedDocument`.
-    /// Includes time based validation of the `id` and `ver` fields based on the provided
-    /// `future_threshold` and `past_threshold` threshold values (in seconds).
-    /// Return true if it is valid, otherwise return false.
+    /// If something fails `doc.report()` would be properly filled, so
+    /// `doc.report().is_problematic()` would return `false`.
     ///
     /// # Errors
     /// If `provider` returns error, fails fast throwing that error.
     pub fn validate(
         &self,
         doc: &CatalystSignedDocument,
         provider: &impl Provider,
-    ) -> anyhow::Result<bool> {
+    ) -> anyhow::Result<()> {
         let Ok(doc_type) = doc.doc_type() else {
             doc.report().missing_field(
                 "type",
                 "Can't get a document type during the validation process",
             );
-            return Ok(false);
+            return Ok(());
         };
 
         let Some(rules) = self.0.get(doc_type) else {
@@ -103,16 +102,15 @@ impl Validator {
                 "Must be a known document type value",
                 "Unsupported document type",
             );
-            return Ok(false);
+            return Ok(());
         };
 
-        let res = rules
+        rules
             .iter()
             .map(|v| v.check(doc, provider))
-            .collect::<anyhow::Result<Vec<_>>>()?
-            .iter()
-            .all(|res| *res);
-        Ok(res)
+            .collect::<anyhow::Result<Vec<_>>>()?;
+
+        Ok(())
     }
 
     /// Extend the current defined validation rules set for the provided document type.

rust/signed_doc/tests/brand_parameters.rs

@@ -135,8 +135,7 @@ fn test_brand_parameters_doc(
         doc_types::BRAND_PARAMETERS.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }

rust/signed_doc/tests/brand_parameters_form_template.rs

@@ -96,8 +96,7 @@ fn test_brand_parameters_form_template_doc(
         doc_types::BRAND_PARAMETERS_FORM_TEMPLATE.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }

rust/signed_doc/tests/campaign_parameters.rs

@@ -182,8 +182,7 @@ fn test_campaign_parameters_doc(
         doc_types::CAMPAIGN_PARAMETERS.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }

rust/signed_doc/tests/campaign_parameters_form_template.rs

@@ -138,8 +138,7 @@ fn test_campaign_parameters_form_template_doc(
         doc_types::CAMPAIGN_PARAMETERS_FORM_TEMPLATE.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }

rust/signed_doc/tests/category_parameters.rs

@@ -195,8 +195,7 @@ fn test_category_parameters_doc(
         doc_types::CATEGORY_PARAMETERS.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }

rust/signed_doc/tests/category_parameters_form_template.rs

@@ -147,8 +147,7 @@ fn test_category_parameters_form_template_doc(
         doc_types::CATEGORY_PARAMETERS_FORM_TEMPLATE.clone()
     );
 
-    let is_valid = Validator::new().validate(&doc, &provider).unwrap();
-    assert_eq!(is_valid, !doc.report().is_problematic());
+    Validator::new().validate(&doc, &provider).unwrap();
     println!("{:?}", doc.report());
-    is_valid
+    !doc.report().is_problematic()
 }