Skip to content

Commit e0271cd

Browse files
committed
fix: extend default timeout to 5 minutes (#683)
Refs: ETCM-9741
1 parent 841dc10 commit e0271cd

File tree

11 files changed

+28
-30
lines changed

11 files changed

+28
-30
lines changed

changelog.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,34 +2,32 @@
22

33
This changelog is based on [Keep A Changelog](https://keepachangelog.com/en/1.1.0).
44

5-
# Unreleased
5+
# v1.6.1
66

77
## Changed
88

9-
## Removed
9+
* Default `smart-contracts` timeout from 2 minutes to 5 minutes
1010

1111
## Fixed
1212

13-
## Added
14-
15-
# v1.6.1
13+
* `governance init` when genesis utxo had a script attached, then transaction fee was sometimes calculated incorrectly
1614

17-
## Fixed
15+
## Removed
1816

19-
* `governance init` when genesis utxo had a script attached, then transaction fee was sometimes calculated incorrectly
17+
* Removed unnecessary transitive dependencies from multiple crates
2018

2119
# v1.6.0
2220

2321
## Changed
2422

25-
* Split MainchainPublicKey to StakePoolPublicKey and StakePublicKey. Some parameters names has been changed as well, so potentially compiliation of downstream projects could be broken.
23+
* Split MainchainPublicKey to StakePoolPublicKey and StakePublicKey. Some parameters names has been changed as well, so potentially compilation of downstream projects could be broken.
2624
* Update polkadot-sdk to polkadot-stable2412-1.
2725
WARNING: Benchmarking command has been removed, because `frame-benchmarking-cli` crate became GPLv3 without any exception.
2826
* Made Cardano slot duration configurable with default of 1000ms. If your partner chain's main chain is Cardano
2927
mainnet or one of the official testnets, you don't need to change anything. Otherwise, the duration can
3028
be set through `MC__SLOT_DURATION_MILLIS` environment variable.
3129
* e2e-tests: updated python to 3.12 and libs versions.
32-
* Committee member data stored by the Session Validator Management Pallet is now fullly generic. To migrate to this version,
30+
* Committee member data stored by the Session Validator Management Pallet is now fully generic. To migrate to this version,
3331
define your own `CommitteeMember` type and implement the trait `CommitteeMember` for it. See the `CommitteeMember`
3432
type implemented in `node/runtime/src/lib.rs` for reference using Ariadne.
3533
* Merged functionality of `NativeTokenManagementInherentDataProvider::new_if_pallet_present` into `new`. Use this single constructor from now on.
@@ -43,7 +41,7 @@ type implemented in `node/runtime/src/lib.rs` for reference using Ariadne.
4341
## Added
4442

4543
* block-production-log pallet, see it's readme for more details.
46-
* Block participaton pallet and inherent data provider, making available data on block producers
44+
* Block participation pallet and inherent data provider, making available data on block producers
4745
and their delegators. This feature is meant to be used by Partner Chains developers to implement
4846
block production reward payouts in their own runtimes. See `toolkit/primitives/block-participation/README.md`
4947
for more information.
@@ -135,7 +133,7 @@ provider will not query the main chain state or produce inherent data at all.
135133
* * Specific changes will depend on the node implementation.
136134
* Update toolchain to 1.81.0
137135
* Implemented batch queries and caching for the native token observability. Improves performance of the full-sync.
138-
* Added ogmios-client interal library for communication with Ogmios
136+
* Added ogmios-client internal library for communication with Ogmios
139137
* Using Ogmios for reading Cardano Network parameters in `partner-chains-cli`, instead of asking user to choose them
140138
* Bugfix: rephrased vague log message when selecting the epoch committee
141139
* Removed the `main-chain-follower-api` completely. Each crate that depended on it now defines its own `*DataSource`

toolkit/cli/smart-contracts-commands/src/d_parameter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ impl UpsertDParameterCmd {
3232
&d_param,
3333
&payment_key,
3434
&client,
35-
&FixedDelayRetries::two_minutes(),
35+
&FixedDelayRetries::five_minutes(),
3636
)
3737
.await?;
3838

toolkit/cli/smart-contracts-commands/src/governance.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl InitGovernanceCmd {
4747
&payment_key,
4848
self.genesis_utxo,
4949
&client,
50-
FixedDelayRetries::two_minutes(),
50+
FixedDelayRetries::five_minutes(),
5151
)
5252
.await?;
5353
Ok(())
@@ -78,7 +78,7 @@ impl UpdateGovernanceCmd {
7878
&payment_key,
7979
self.genesis_utxo,
8080
&client,
81-
FixedDelayRetries::two_minutes(),
81+
FixedDelayRetries::five_minutes(),
8282
)
8383
.await?;
8484

toolkit/cli/smart-contracts-commands/src/permissioned_candidates.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ impl UpsertPermissionedCandidatesCmd {
4848
&permissioned_candidates,
4949
&payment_key,
5050
&client,
51-
&FixedDelayRetries::two_minutes(),
51+
&FixedDelayRetries::five_minutes(),
5252
)
5353
.await?;
5454

toolkit/cli/smart-contracts-commands/src/register.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ impl RegisterCmd {
6161
&candidate_registration,
6262
&payment_key,
6363
&client,
64-
FixedDelayRetries::two_minutes(),
64+
FixedDelayRetries::five_minutes(),
6565
)
6666
.await?;
6767

@@ -93,7 +93,7 @@ impl DeregisterCmd {
9393
&payment_signing_key,
9494
self.spo_public_key,
9595
&client,
96-
FixedDelayRetries::two_minutes(),
96+
FixedDelayRetries::five_minutes(),
9797
)
9898
.await?;
9999

toolkit/cli/smart-contracts-commands/src/reserve.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ impl InitReserveCmd {
6262
self.genesis_utxo,
6363
&payment_key,
6464
&client,
65-
&FixedDelayRetries::two_minutes(),
65+
&FixedDelayRetries::five_minutes(),
6666
)
6767
.await?;
6868
Ok(())
@@ -102,7 +102,7 @@ impl CreateReserveCmd {
102102
self.genesis_utxo,
103103
&payment_key,
104104
&client,
105-
&FixedDelayRetries::two_minutes(),
105+
&FixedDelayRetries::five_minutes(),
106106
)
107107
.await?;
108108
Ok(())
@@ -132,7 +132,7 @@ impl DepositReserveCmd {
132132
self.genesis_utxo,
133133
&payment_key,
134134
&client,
135-
&FixedDelayRetries::two_minutes(),
135+
&FixedDelayRetries::five_minutes(),
136136
)
137137
.await?;
138138
Ok(())
@@ -162,7 +162,7 @@ impl UpdateReserveSettingsCmd {
162162
&payment_key,
163163
self.total_accrued_function_script_hash,
164164
&client,
165-
&FixedDelayRetries::two_minutes(),
165+
&FixedDelayRetries::five_minutes(),
166166
)
167167
.await?;
168168
Ok(())
@@ -188,7 +188,7 @@ impl HandoverReserveCmd {
188188
self.genesis_utxo,
189189
&payment_key,
190190
&client,
191-
&FixedDelayRetries::two_minutes(),
191+
&FixedDelayRetries::five_minutes(),
192192
)
193193
.await?;
194194
Ok(())
@@ -222,7 +222,7 @@ impl ReleaseReserveCmd {
222222
self.reference_utxo,
223223
&payment_key,
224224
&client,
225-
&FixedDelayRetries::two_minutes(),
225+
&FixedDelayRetries::five_minutes(),
226226
)
227227
.await?;
228228
Ok(())

toolkit/offchain/src/await_tx.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ impl FixedDelayRetries {
2323
Self { delay, retries }
2424
}
2525

26-
pub fn two_minutes() -> Self {
27-
Self { delay: Duration::from_secs(5), retries: 23 }
26+
pub fn five_minutes() -> Self {
27+
Self { delay: Duration::from_secs(5), retries: 59 }
2828
}
2929
}
3030

toolkit/offchain/src/d_param/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl<C: QueryLedgerState + QueryNetwork + Transactions + QueryUtxoByUtxoId> Upse
4747
d_parameter,
4848
payment_signing_key,
4949
self,
50-
&FixedDelayRetries::two_minutes(),
50+
&FixedDelayRetries::five_minutes(),
5151
)
5252
.await
5353
}

toolkit/offchain/src/init_governance/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ where
4747
payment_key,
4848
Some(genesis_utxo_id),
4949
self,
50-
FixedDelayRetries::two_minutes(),
50+
FixedDelayRetries::five_minutes(),
5151
)
5252
.await
5353
.map(|(_, tx)| tx)

toolkit/offchain/src/permissioned_candidates.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ impl<C: QueryLedgerState + QueryNetwork + Transactions + QueryUtxoByUtxoId>
5151
candidates,
5252
payment_signing_key,
5353
self,
54-
&FixedDelayRetries::two_minutes(),
54+
&FixedDelayRetries::five_minutes(),
5555
)
5656
.await
5757
}

0 commit comments

Comments
 (0)