Review comments

Author: j-mueller

src/programmable-tokens/lib/SmartTokens/Contracts/Issuance.hs

@@ -119,9 +119,6 @@ mkProgrammableLogicMinting = plam $ \(pfromData -> programmableLogicBase) mintin
           # plam (pfstBuiltin #)
           # pto (pfromData ptxInfo'wdrl)
   red <- plet pscriptContext'redeemer
-  -- PMintPToken is used to register a new programmable token in the directory and to mint the programmable token upon registration and
-  -- in any subsequent transaction.
-  -- At registration this creates a permanent association between the currency symbol with a transferLogicScript and issuerLogicScript.
   -- All transfers of the token will be validated by either the transferLogicScript or the issuerLogicScript.
   -- Registration can only occurr once per instance of this minting policy since the directory contracts do not permit duplicate
   -- entries.
@@ -144,7 +141,7 @@ mkProgrammableLogicMinting = plam $ \(pfromData -> programmableLogicBase) mintin
           ]
       )
 
--- | Check that exactly one redeemer with the mintingLogic credential is present in the transaction.
+-- | Check that exactly one `PMinting` redeemer with the mintingLogic credential is present in the transaction.
 psingleMintWithCredential :: Term (s :: S) (PAsData PRedeemer :--> AssocMap.PMap 'AssocMap.Unsorted PScriptPurpose PRedeemer :--> PBool)
 psingleMintWithCredential =
   phoistAcyclic $ plam $ \rdmr redeemers ->

src/programmable-tokens/lib/SmartTokens/LinkedList/MintDirectory.hs

@@ -49,7 +49,7 @@ PlutusTx.makeIsDataIndexed ''DirectoryNodeAction
 
 data PDirectoryNodeAction (s :: S)
   = PInit
-  | PInsert { pkeyToInsert :: Term s (PAsData PByteString), phashedParam :: Term s (PAsData PByteString) }
+  | PInsert { pkeyToInsert :: Term s (PAsData PByteString), pmintingLogicCred :: Term s (PAsData PByteString) }
   deriving stock (Generic)
   deriving anyclass (SOP.Generic, PIsData, PEq)
   deriving (PlutusType) via DeriveAsDataStruct PDirectoryNodeAction
@@ -77,6 +77,6 @@ mkDirectoryNodeMP = plam $ \initUTxO issuanceCborHexCS ctx -> P.do
       passert "Init must consume TxOutRef" $
         phasUTxO # pfromData initUTxO # pfromData ptxInfo'inputs
       pInit common
-    PInsert action hashedParam -> P.do
+    PInsert action pmintingLogicCred -> P.do
       pkToInsert <- plet action
-      pInsert issuanceCborHexCS common # pfromData pkToInsert # hashedParam
+      pInsert issuanceCborHexCS common # pfromData pkToInsert # pmintingLogicCred