Skip to content

Commit 5ca54ab

Browse files
authored
Merge branch 'master' into fix-stale-detection-intervals
2 parents ccc1cc4 + 7e379ca commit 5ca54ab

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

lib/Thruk/Backend/Manager.pm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1715,13 +1715,13 @@ sub _do_on_peers {
17151715
if($num_selected_backends == $num_failed) {
17161716
$err = join("\n", map { Thruk::Utils::Filter::peer_name($_).": ".$c->stash->{'failed_backends'}->{$_} } sort keys %{$c->stash->{'failed_backends'}});
17171717
}
1718-
}
17191718

1720-
# cleanup errors a bit, but print them first to debug log
1721-
if(!$err) {
17221719
my $details_err = join("\n", map { Thruk::Utils::Filter::peer_name($_).": ".$c->stash->{'failed_backends'}->{$_} } sort keys %{$c->stash->{'failed_backends'}});
17231720
_debug($details_err);
17241721
_debug2(Carp::longmess("backend error"));
1722+
} elsif ($err) {
1723+
my($short_err, undef) = Thruk::Utils::extract_connection_error($err);
1724+
$con_errors = $num_selected_backends if defined $short_err;
17251725
}
17261726

17271727
&timing_breakpoint('_get_result: '.$function);
@@ -1730,7 +1730,7 @@ sub _do_on_peers {
17301730
$err = join("\n", map { Thruk::Utils::Filter::peer_name($_).": ".$c->stash->{'failed_backends'}->{$_} } sort keys %{$c->stash->{'failed_backends'}});
17311731
}
17321732
# this means, this is a connection error -> debug log only
1733-
if($con_errors > 0 && $con_errors == scalar keys %{$c->stash->{'failed_backends'}}) {
1733+
if($con_errors > 0 && $con_errors == $num_selected_backends) {
17341734
_debug($err);
17351735
_debug2(Carp::longmess("backend error"));
17361736
my($short_err, undef) = Thruk::Utils::extract_connection_error($err);
@@ -2111,7 +2111,7 @@ sub _get_result_lmd_with_retries {
21112111
my $err = $@;
21122112
return($result, $type, $totalsize, undef) unless $err;
21132113

2114-
_debug($err) if $err;
2114+
_trace($err) if $err;
21152115
if($err && $err =~ m/^502:|bad\ request:/mx) { # lmd sends error 502 if all backends are down
21162116
$c->stash->{'lmd_ok'} = 1;
21172117
}

0 commit comments

Comments
 (0)