trying to pass CI tests

- add files of this PR to manifest,
- modify csv API test functions to beware of quotation marks
- save template file in "UTF-8 BOM" encoding
- read and print the data according to data type in csv renderer

Author: Ahmet Oeztuerk

MANIFEST

@@ -166,6 +166,7 @@ lib/Thruk/Utils/SelfCheck.pm
 lib/Thruk/Utils/Status.pm
 lib/Thruk/Utils/Timezone.pm
 lib/Thruk/Utils/Trends.pm
+lib/Thruk/Views/CsvRenderer.pm
 lib/Thruk/Views/ExcelRenderer.pm
 lib/Thruk/Views/GDRenderer.pm
 lib/Thruk/Views/JSONRenderer.pm
@@ -3178,6 +3179,7 @@ templates/_backends_select_multi.tt
 templates/_blocks.tt
 templates/_cmd_form.tt
 templates/_cmd_parts.tt
+templates/_csv_export.tt
 templates/_comments_table.tt
 templates/_common_css.tt
 templates/_common_css_fonts.tt
@@ -3380,6 +3382,8 @@ templates/config_timeperiods.tt
 templates/custom_perf_bar_adjustments.tt
 templates/docs.tt
 templates/error.tt
+templates/csv/_status_hostdetail.tt
+templates/csv/status_hostdetail.tt
 templates/excel/_status_detail_worksheet.tt
 templates/excel/_status_hostdetail_worksheet.tt
 templates/excel/availability.tt

lib/Thruk/Views/CsvRenderer.pm

@@ -36,7 +36,25 @@ sub render_csv {
     my $t1 = [gettimeofday];
     require Thruk::Views::ToolkitRenderer;
     my $output = '';
-    Thruk::Views::ToolkitRenderer::render($c, $c->stash->{'template'}, undef, \$output);
+
+    if (defined $data && ref($data) eq 'ARRAY') {
+        foreach my $row (@{$data}) {
+            if (ref($row) eq 'ARRAY') {
+                $output .= join(',', map { "\"$_\"" } (@{$row}) ) . "\n";
+            } else {
+                $output .= "\"$row\"\n";
+            }
+        }
+    } elsif (defined $data && ref($data) eq 'HASH') {
+        # Handle hash data
+        my @keys = sort keys (%{$data});
+        $output .= join(',', map { "\"$_\"" } @keys) . "\n";
+        $output .= join(',', map { "\"$data->{$_}\"" } @keys) . "\n";
+    } else {
+        # Fallback for scalar data
+        $output = defined $data ? "$data\n" : "";
+    }
+
     $c->{'rendered'} = 1;
     $c->res->content_type('text/csv');
     $c->res->body($output);

t/scenarios/rest_api/t/local/rest_functions.t

@@ -49,7 +49,7 @@ TestUtils::test_command({
 {
     TestUtils::test_command({
         cmd  => '/usr/bin/env thruk r "/csv/hosts?columns=concat(name, \"_\", state, \"::\") as test"',
-        like => [qr/^#test$/smx, qr/^localhost_\d::$/smx],
+        like => [qr/^#test$/smx, qr/^"localhost_\d::"$/smx],
     });
 };
 
@@ -71,7 +71,7 @@ TestUtils::test_command({
     });
     TestUtils::test_command({
         cmd  => '/usr/bin/env thruk r "/csv/hosts?columns=fmt(\"%s:%.3f\", name, state) as test"',
-        like => [qr/^#test$/smx, qr/^localhost:\d\.000$/smx],
+        like => [qr/^#test$/smx, qr/^"localhost:\d\.000"$/smx],
     });
 };
 
@@ -137,7 +137,7 @@ TestUtils::test_command({
 {
     TestUtils::test_command({
         cmd  => '/usr/bin/env thruk r "/csv/hosts?columns=utc(last_check) as test"',
-        like => [qr/^#test$/smx, qr/^\d+\-\d+\-\d+\s+\d+:\d+:\d+\s+UTC$/smx],
+        like => [qr/^#test$/smx, qr/^\"\d+\-\d+\-\d+\s+\d+:\d+:\d+\s+UTC\"$/smx],
     });
 };
 
@@ -146,7 +146,7 @@ TestUtils::test_command({
 {
     TestUtils::test_command({
         cmd  => '/usr/bin/env thruk r "/csv/hosts?columns=date(last_check) as test"',
-        like => [qr/^#test$/smx, qr/^\d+\-\d+\-\d+\s+\d+:\d+:\d+/smx],
+        like => [qr/^#test$/smx, qr/^\"\d+\-\d+\-\d+\s+\d+:\d+:\d+/smx],
     });
 };
 

templates/csv/_status_hostdetail.tt

@@ -1,4 +1,4 @@
-[% USE date %]
+[% USE date %]
 [% FOREACH col = columns %]
   [% IF col == "Site"                         %]Site,
   [% ELSIF col == "Hostname"                  %]Hostname,