Fix: Cognito page (#277)

* Fix: Cognito page

- replace deprecated waitForNavigation with waitForURL

- use selectors that work across browsers/devices

* change from type to name as type is not a valid option of getByRole

* change IDP URL to RegExp matching anything since we only want to wait for navigation anywhere

Author: VirginiaBalseiro

packages/internal-playwright-helpers/src/pages/cognito.ts

@@ -33,13 +33,13 @@ export class CognitoPage {
   }
 
   async login(username: string, password: string) {
-    await this.page.fill(".visible-lg [type=text]", username);
-    await this.page.fill(".visible-lg [type=password]", password);
+    await this.page.getByRole('textbox', { name: 'Username' }).fill(username);
+    await this.page.getByRole('textbox', { name: 'Password' }).fill(password);
     await Promise.all([
-      // It is important to call waitForNavigation before click to set up waiting.
-      this.page.waitForNavigation(),
-      // Clicking the link will indirectly cause a navigation.
-      this.page.click(".visible-lg [aria-label=submit]"),
+        // It is important to call waitForURL before click to set up waiting.
+        this.page.waitForURL(/.*/),
+        // Clicking the link will indirectly cause a navigation.
+        this.page.getByRole('button', { name: 'submit' }).click(),
     ]);
   }
 }