fix factor to integer bug

Author: alanahjonas95

R/rename_ard_columns.R

@@ -125,6 +125,12 @@ rename_ard_columns <- function(x,
     dplyr::select(-"...ard_row_order...") |>
     dplyr::mutate(
       # replace NULL values with NA, then unlist
-      across(all_of(all_new_names), ~ map(., \(value) value %||% NA) |> unlist())
+      across(
+        all_of(all_new_names),
+        ~ map(., \(value){
+           if (inherits(value, "factor")) value <- as.character(value)
+       value %||% NA
+    })|>
+      unlist())
     )
 }

tests/testthat/test-rename_ard_columns.R

@@ -53,3 +53,24 @@ test_that("rename_ard_columns(unlist) lifecycle", {
       rename_ard_columns(unlist = "stat")
   )
 })
+
+
+test_that("rename_ard_columns() preserves factor levels as characters", {
+  adsl_ <- ADSL |>
+    dplyr::mutate(
+      RACE = factor(RACE, levels = c("WHITE", "BLACK OR AFRICAN AMERICAN", "AMERICAN INDIAN OR ALASKA NATIVE"))
+    )
+
+  res <- ard_tabulate(
+    data = adsl_,
+    by = TRT01A,
+    variables = RACE
+  ) |>
+  rename_ard_columns()
+
+  # Check that 'race' is a character vector
+  expect_type(res$RACE, "character")
+
+  # Check that it contains the actual level string, not an integer "1", "2", etc.
+  expect_true("WHITE" %in% res$RACE)
+})