addresses https://github.com/insightsengineering/rtables/issues/1056#1057
Merged
shajoezhu merged 2 commits intoinsightsengineering:mainfrom Nov 26, 2025
Merged
Conversation
eanokian
requested review from
Melkiades,
ayogasekaram and
edelarua
as code owners
Contributor
|
✅ All contributors have signed the CLA |
Melkiades
reviewed
Nov 24, 2025
Contributor
Melkiades
left a comment
Melkiades
left a comment
There was a problem hiding this comment.
For me it is good to go! Thanks for the fix! @shajoezhu ?
Contributor
Author
|
feel free to add @gmbecker as reviewer as well |
Collaborator
|
@eanokian please "sign" the CLA per the instructions above |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Done, I have also fixed some linting issues. I think the GitHub workflow is waiting for a maintainer to approve the PR before triggering the R CMD check. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1056