-
-
Notifications
You must be signed in to change notification settings - Fork 19
Adds CSS visibily expectation to TealAppDriver that use JS and wait accordingly
#1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TealAppDriver that use JS and wait accordinglyTealAppDriver that use JS and wait accordingly
|
This should be a straightforward review. All tests pass on my laptop some hours ago, I only had an issue with the Running this action to see if CI can replicate it: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/20338548771 |
Unit Tests Summary 1 files ± 0 71 suites ±0 1h 50m 30s ⏱️ + 1h 49m 9s For more details on these failures, see this check. Results for commit 9ef6e87. ± Comparison against base commit 6ea33d5. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 02e7473 ♻️ This comment has been updated with latest results. |

Pull Request
Implements
expectationfor visibility usingAppDriver$wait_for_jsAPI that is more robust than immediate execution.