Skip to content

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Dec 9, 2025

Pull Request

Implements expectation for visibility using AppDriver$wait_for_js API that is more robust than immediate execution.

@averissimo averissimo added the core label Dec 9, 2025
@averissimo averissimo changed the title Adds CSS visibily expecation to TealAppDriver that use JS and wait accordingly Adds CSS visibily expectation to TealAppDriver that use JS and wait accordingly Dec 9, 2025
@osenan osenan self-assigned this Dec 17, 2025
@averissimo
Copy link
Contributor Author

averissimo commented Dec 18, 2025

This should be a straightforward review. All tests pass on my laptop some hours ago, I only had an issue with the test-examples which is out of the scope of this PR, but not from the parent one :-)

Running this action to see if CI can replicate it: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/20338548771

@llrs-roche llrs-roche requested a review from osenan December 18, 2025 15:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Unit Tests Summary

    1 files  ±    0     71 suites  ±0   1h 50m 30s ⏱️ + 1h 49m 9s
  734 tests ±    0    726 ✅ +  571  0 💤  - 579  8 ❌ +8 
2 025 runs  +1 151  2 017 ✅ +1 841  0 💤  - 698  8 ❌ +8 

For more details on these failures, see this check.

Results for commit 9ef6e87. ± Comparison against base commit 6ea33d5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.24$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.65$ $+7.45$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.56$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.10$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.20$ $+2.68$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.37$ $+3.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.23$ $+1.81$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.36$ $+4.61$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.32$ $+6.91$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.11$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.33$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.36$ $+1.97$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.17$ $+1.30$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.14$ $+1.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+2.98$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.42$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.27$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.16$ $+1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.12$ $+1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.13$ $+1.48$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_km 👶 $+0.13$ e2e_tm_g_km_Starts_with_collapsed_additional_plot_settings.
shinytest2-tm_g_km 💀 $0.01$ $-0.01$ e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.

Results for commit 02e7473

♻️ This comment has been updated with latest results.

@osenan
Copy link

osenan commented Dec 19, 2025

The tests pass for me locally!
image
Please just remember not to keep harcoded the branch to execute the CI

@averissimo averissimo merged commit 49ac398 into bring_tests Dec 23, 2025
25 of 27 checks passed
@averissimo averissimo deleted the visibility_feat@bring_tests branch December 23, 2025 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants