Updates webR quarto extension to fix problem#305
Conversation
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
Unit Tests Summary340 tests 252 ✅ 1m 1s ⏱️ Results for commit d805c34. ♻️ This comment has been updated with latest results. |
|
There are a bunch of snapshots failing both in There are (at least) 3 types of snapshot failures:
── Failure ('test-tables-lab-results-lbt14.R:1:1'): tables/lab-results/lbt14.qmd result_v1 stable ──
Snapshot of code has changed (variant 'stable'):
old[10:65] vs new[10:65]
Not High 134 (100%) 134 (100%) 132 (100%)
C-Reactive Protein Measurement
Not High 114 112 115
- Not High 45 (33.6%) 55 (41.0%) 57 (43.2%)
+ Not High 45 (39.5%) 55 (49.1%) 57 (49.6%)
- 1 18 (13.4%) 18 (13.4%) 19 (14.4%)
+ 1 18 (15.8%) 18 (16.1%) 19 (16.5%)
- 2 19 (14.2%) 10 (7.5%) 11 (8.3%)
+ 2 19 (16.7%) 10 (8.9%) 11 (9.6%)
- 3 22 (16.4%) 13 (9.7%) 20 (15.2%)
+ 3 22 (19.3%) 13 (11.6%) 20 (17.4%)
- 4 10 (7.5%) 16 (11.9%) 8 (6.1%)
+ 4 10 (8.8%) 16 (14.3%) 8 (7.0%)
1 8 10 7
- Not High 5 (3.7%) 2 (1.5%) 2 (1.5%)
+ Not High 5 (62.5%) 2 (20.0%) 2 (28.6%) Should the different snapshots be accepted, or should we use |
You can accept the changes as is. Thanks! |
pawelru
left a comment
There was a problem hiding this comment.
Thanks! Does that really solves that issue about xfun?
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
|
I believe so, in my local tests, the issue is gone. |
Changes description