Skip to content

Updates webR quarto extension to fix problem#305

Merged
averissimo merged 4 commits intomainfrom
304-fix_xfun_failure
Apr 14, 2025
Merged

Updates webR quarto extension to fix problem#305
averissimo merged 4 commits intomainfrom
304-fix_xfun_failure

Conversation

@averissimo
Copy link
Contributor

Changes description
  • Updates quarto extension

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@averissimo averissimo marked this pull request as ready for review April 11, 2025 12:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Unit Tests Summary

340 tests   252 ✅  1m 1s ⏱️
135 suites   88 💤
  1 files      0 ❌

Results for commit d805c34.

♻️ This comment has been updated with latest results.

@averissimo
Copy link
Contributor Author

There are a bunch of snapshots failing both in main (triggered a manual check that is failing here) and in this PR.

There are (at least) 3 types of snapshot failures:

  • denom = "n" just like the one below
  • Differences in spacing
  • .labels not assigning the correct stat name (fixed in this PR)
  ── Failure ('test-tables-lab-results-lbt14.R:1:1'): tables/lab-results/lbt14.qmd result_v1 stable ──
  Snapshot of code has changed (variant 'stable'):
  old[10:65] vs new[10:65]
                    Not High                        134 (100%)   134 (100%)     132 (100%)  
      C-Reactive Protein Measurement                                                        
            Not High                                   114          112            115      
  -                 Not High                        45 (33.6%)   55 (41.0%)     57 (43.2%)  
  +                 Not High                        45 (39.5%)   55 (49.1%)     57 (49.6%)  
  -                 1                               18 (13.4%)   18 (13.4%)     19 (14.4%)  
  +                 1                               18 (15.8%)   18 (16.1%)     19 (16.5%)  
  -                 2                               19 (14.2%)   10 (7.5%)      11 (8.3%)   
  +                 2                               19 (16.7%)   10 (8.9%)      11 (9.6%)   
  -                 3                               22 (16.4%)   13 (9.7%)      20 (15.2%)  
  +                 3                               22 (19.3%)   13 (11.6%)     20 (17.4%)  
  -                 4                               10 (7.5%)    16 (11.9%)      8 (6.1%)   
  +                 4                               10 (8.8%)    16 (14.3%)      8 (7.0%)   
            1                                           8            10             7       
  -                 Not High                         5 (3.7%)     2 (1.5%)       2 (1.5%)   
  +                 Not High                        5 (62.5%)    2 (20.0%)      2 (28.6%)   

Should the different snapshots be accepted, or should we use denom = "N_col" in the code? @insightsengineering/nest-sme ?

@averissimo averissimo enabled auto-merge (squash) April 11, 2025 15:26
@edelarua
Copy link
Contributor

Should the different snapshots be accepted, or should we use denom = "N_col" in the code?

You can accept the changes as is. Thanks!

Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does that really solves that issue about xfun?

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
@averissimo averissimo merged commit 4e4047c into main Apr 14, 2025
@averissimo averissimo deleted the 304-fix_xfun_failure branch April 14, 2025 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
@averissimo
Copy link
Contributor Author

I believe so, in my local tests, the issue is gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: webr problems on stable and dev version

3 participants