Skip to content

Commit 9ebcb9e

Browse files
authored
version bumps (#40)
* Uses Parameter in log statement * Removes unnecessary dependency to gRPC * Uses current versions of dependencies * Uses version of lombok from Spring Boot BOM * Switches to TaskProviders This is one step to defer task creation. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html * Uses non-deprecated property * Declares an explicit dependency on Task outputs This avoids some warning messages while running gradle
1 parent ba80826 commit 9ebcb9e

4 files changed

Lines changed: 19 additions & 25 deletions

File tree

build.gradle

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ if (!project.hasProperty("buildVersion") || project.getProperty("buildVersion").
2222

2323
version = "$buildVersion"
2424

25-
task downloadBoomerangjs() {
25+
tasks.register('downloadBoomerangjs') {
2626
logger.info("Downloading Boomerangjs version {}.", boomerangVersion)
2727
ext.dest = new File(buildDir, "boomerang-source-${boomerangVersion}.tgz")
2828
outputs.files(ext.dest)
@@ -33,17 +33,18 @@ task downloadBoomerangjs() {
3333
}
3434
}
3535

36-
task deleteBoomerangjs(type: Delete) {
36+
tasks.register('deleteBoomerangjs', Delete) {
3737
delete new File(project.buildDir, "boomerangjs-${boomerangVersion}")
3838
}
3939

40-
task downloadAndExtractBoomerang(dependsOn: [deleteBoomerangjs, downloadBoomerangjs], type: Copy) {
40+
tasks.register ('downloadAndExtractBoomerang', Copy) {
41+
dependsOn deleteBoomerangjs, downloadBoomerangjs
4142
from tarTree(downloadBoomerangjs.dest)
4243
into new File(project.buildDir, "boomerangjs-${boomerangVersion}")
4344
filter { line -> line.replaceAll("%boomerang_version%", "${boomerangVersion}") }
4445
}
4546

46-
task generateVersionFile {
47+
tasks.register('generateVersionFile') {
4748
ext.versionFile = new File(project.buildDir, "eum-version.info")
4849
doLast {
4950
def currentDate = new Date().toString()
@@ -53,7 +54,7 @@ task generateVersionFile {
5354
}
5455
}
5556

56-
task downloadOpenTelemetryPlugin() {
57+
tasks.register('downloadOpenTelemetryPlugin') {
5758
ext.dest = new File(buildDir, "boomerang-opentelemetry.js")
5859
outputs.files(ext.dest)
5960
doLast {
@@ -70,7 +71,7 @@ bootJar {
7071
dependsOn downloadOpenTelemetryPlugin
7172

7273
archivesBaseName = "inspectit-ocelot-eum-server"
73-
version = "${buildVersion}"
74+
archiveVersion = "${buildVersion}"
7475

7576
manifest {
7677
attributes "Start-Class": "rocks.inspectit.oce.eum.server.EUMServerApplication"
@@ -126,9 +127,6 @@ dependencies {
126127
"io.opencensus:opencensus-impl:${openCensusVersion}",
127128
"io.opencensus:opencensus-exporter-stats-prometheus:${openCensusVersion}",
128129

129-
"io.grpc:grpc-netty-shaded:${grpcVersion}",
130-
"io.grpc:grpc-protobuf:${grpcVersion}",
131-
"io.grpc:grpc-stub:${grpcVersion}",
132130
platform("io.opentelemetry:opentelemetry-bom-alpha:${openTelemetryAlphaVersion}"),
133131
"io.opentelemetry:opentelemetry-semconv",
134132
platform("io.opentelemetry:opentelemetry-bom:${openTelemetryVersion}"),
@@ -154,8 +152,8 @@ dependencies {
154152
"rocks.inspectit:opencensus-influxdb-exporter:${opencensusInfluxdbExporterVersion}",
155153
)
156154

157-
compileOnly "org.projectlombok:lombok:${lombokVersion}"
158-
annotationProcessor "org.projectlombok:lombok:${lombokVersion}"
155+
compileOnly "org.projectlombok:lombok"
156+
annotationProcessor "org.projectlombok:lombok"
159157

160158
testImplementation(
161159
"org.springframework.boot:spring-boot-starter-test",
@@ -180,7 +178,7 @@ dependencies {
180178
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
181179
}
182180

183-
task copyServerJar(type: Copy) {
181+
tasks.register('copyServerJar', Copy) {
184182
dependsOn bootJar
185183
from("${buildDir}/libs/inspectit-ocelot-eum-server-${version}.jar")
186184
into("${buildDir}/docker-jar")
@@ -193,5 +191,5 @@ docker {
193191
name "inspectit/inspectit-ocelot-eum-server"
194192
tags "${version}"
195193
dockerfile file("docker/Dockerfile")
196-
files "docker/entrypoint.sh", "$buildDir/docker-jar/inspectit-ocelot-eum-server.jar"
194+
files "docker/entrypoint.sh", copyServerJar.outputs
197195
}

gradle.properties

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,10 @@ openCensusVersion=0.31.1
1616
# pin Prometheus client to 0.6.0 to prevent auto prefixing counter metrics with "_total"
1717
# see: https://github.com/prometheus/client_java/issues/640, https://github.com/prometheus/client_java/pull/653
1818
prometheusClientVersion = 0.6.0
19-
lombokVersion=1.18.26
20-
openTelemetryVersion=1.24.0
21-
openTelemetryAlphaVersion=1.24.0-alpha
19+
openTelemetryVersion=1.25.0
20+
openTelemetryAlphaVersion=1.25.0-alpha
2221
openTelemetryProtoVersion=1.7.1-alpha
23-
grpcVersion=1.53.0
24-
protobufVersion=3.22.2
22+
protobufVersion=3.22.3
2523
guavaVersion=31.1-jre
2624
# there are newer version, but they are not compatible with Java 8
2725
geoip2Version=2.16.1
@@ -30,8 +28,8 @@ commonsMath3Version=3.6.1
3028
commonsIoVersion=2.11.0
3129
influxdbJavaVersion=2.23
3230
opencensusInfluxdbExporterVersion=1.2
33-
armeriaVersion=1.22.1
34-
testContainersVersion=1.17.6
31+
armeriaVersion=1.23.1
32+
testContainersVersion=1.18.0
3533

3634
### gradle plugin versions
3735
### Check for newer version at https://plugins.gradle.org/
@@ -42,4 +40,5 @@ owaspDependencyCheckVersion=8.2.1
4240
# org.cyclonedx.bom
4341
cyclonedxBomVersion=1.7.4
4442
# com.palantir.docker
43+
# There is a newer Version 0.35.0, but it is not Java 8 compatible
4544
palantirDockerVersion=0.34.0

src/main/java/rocks/inspectit/oce/eum/server/exporters/OtlpMetricsExporterService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ private boolean shouldEnable() {
9292
}
9393
if (otlp.getEnabled().equals(ExporterEnabledState.ENABLED)) {
9494
if (!SUPPORTED_PROTOCOLS.contains(otlp.getProtocol())) {
95-
log.warn("OTLP Metric Exporter is enabled, but wrong 'protocol' is specified. Supported values are ", Arrays.toString(SUPPORTED_PROTOCOLS.stream()
96-
.map(transportProtocol -> transportProtocol.getConfigRepresentation())
95+
log.warn("OTLP Metric Exporter is enabled, but wrong 'protocol' is specified. Supported values are {}", Arrays.toString(SUPPORTED_PROTOCOLS.stream()
96+
.map(TransportProtocol::getConfigRepresentation)
9797
.toArray()));
9898
}
9999
if (!StringUtils.hasText(otlp.getEndpoint())) {

src/main/java/rocks/inspectit/oce/eum/server/exporters/configuration/TraceExportersConfiguration.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
package rocks.inspectit.oce.eum.server.exporters.configuration;
22

3-
import io.grpc.ManagedChannel;
4-
import io.grpc.ManagedChannelBuilder;
53
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter;
64
import io.opentelemetry.exporter.jaeger.thrift.JaegerThriftSpanExporter;
75
import io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporter;
86
import io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporterBuilder;
97
import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporter;
108
import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder;
11-
import io.opentelemetry.sdk.resources.Resource;
129
import io.opentelemetry.sdk.trace.export.SpanExporter;
1310
import io.opentelemetry.semconv.resource.attributes.ResourceAttributes;
1411
import lombok.extern.slf4j.Slf4j;

0 commit comments

Comments
 (0)