Skip to content

Commit 9f1c080

Browse files
committed
Adding comments
1 parent c382d42 commit 9f1c080

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

.github/workflows/eumserver_release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
- name: Download eumserver jar
6363
uses: actions/download-artifact@v3
6464
with:
65-
name: eumserver-jar
65+
name: eumserver-jar # with the name we are referencing the eumserver-jar uploaded in the build_and_release job
6666
path: docker/
6767
- name: Check if jar exists and rename it
6868
run: |
@@ -85,5 +85,5 @@ jobs:
8585
with:
8686
context: .
8787
push: true
88-
tags: danipaniii/testing:${{ github.ref_name }}, danipaniii/testing:latest
88+
tags: inspectit/inspectit-ocelot-eum-server${{ github.ref_name }}, inspectit/inspectit-ocelot-eum-server:latest
8989
file: ./docker/Dockerfile

docker/Dockerfile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
FROM openjdk:11-jre-slim
22

3-
ADD ./docker/ /
3+
# The docker directory contains the Dockerfile, entrypoint.sh and the eum-server jar to build the docker image.
4+
# So the docker directory gets added to the container to successfully build the docker image.
5+
# The dockerfile gets build in the docker directory where it is in and no new directories are being created.
6+
# =====
7+
# In order to build a docker image locally, the eum-server should be build locally and the resulting jar should be renamed
8+
# to 'inspectit-ocelot-eum-server.jar' and copied to the ./docker directory
9+
ADD ./docker/ /
410
ENTRYPOINT ["sh", "/entrypoint.sh"]
511

0 commit comments

Comments
 (0)