bump thresholds for SmallClass sniffs (200 LOC/class, 25 LOC/method)

Author: robocoder

Sniffs/ObjectCalisthenics/SmallClassSniff/NodeVisitor.php

@@ -12,19 +12,19 @@ class Symfony2_Sniffs_ObjectCalisthenics_SmallClassSniff_NodeVisitor extends PHP
     private $metaData = array(
         'Stmt_Class' => array(
             'keyword' => 'class',
-            'maximum' => 100,
+            'maximum' => 200,
         ),
         'Stmt_Interface' => array(
             'keyword' => 'interface',
-            'maximum' => 100,
+            'maximum' => 200,
         ),
         'Stmt_Trait' => array(
             'keyword' => 'trait',
-            'maximum' => 100,
+            'maximum' => 200,
         ),
         'Stmt_ClassMethod' => array(
             'keyword' => 'method',
-            'maximum' => 10,
+            'maximum' => 25,
         ),
     );
 

Tests/ObjectCalisthenics/SmallClassUnitTest.inc

@@ -20,6 +20,21 @@ class SmallClassSniffTest
          *
          *
          *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
          */
     }
 
@@ -75,6 +90,61 @@ class SmallClassSniffTest
      *
      *
      *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
+     *
      */
     public function smallMethodBigDocBlock()
     {
@@ -87,6 +157,21 @@ class SmallClassSniffTest
          *
          *
          *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
          */
     }
 
@@ -105,6 +190,21 @@ class SmallClassSniffTest
          *
          *
          *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
+         *
          */
     }
 }

Tests/ObjectCalisthenics/SmallClassUnitTest.php

@@ -53,7 +53,7 @@ public function getWarningList()
     {
         return array(
             7 => 1,
-            96 => 1,
+            181 => 1,
         );
     }
 }

ruleset.xml

@@ -86,13 +86,4 @@
     <rule ref="Symfony2.Commenting.ClassComment.SpacingBeforeTags">
         <message>There should always be a description, followed by a blank line, before the tags of a class comment.</message>
     </rule>
-
-    <!-- Disable these object calisthenic sniffs -->
-    <rule ref="Symfony2.ObjectCalisthenics.SmallClass">
-        <severity>0</severity>
-    </rule>
-
-    <rule ref="Symfony2.ObjectCalisthenics.UseAccessors">
-        <severity>0</severity>
-    </rule>
 </ruleset>