Skip to content

Commit 691a0ea

Browse files
committed
chore: optimized
1 parent 732a547 commit 691a0ea

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

  • packages
    • collector/test/integration/currencies/messaging/amqplib
    • core/src/tracing/instrumentation/messaging

packages/collector/test/integration/currencies/messaging/amqplib/test_base.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,14 @@ module.exports = function (name, version, isLatest) {
205205
it('must propagate suppression downstream for sendToQueue', () =>
206206
publisherControls
207207
.sendToQueue('Ohai', { 'X-INSTANA-L': 0 })
208-
.then(() => delay(500))
208+
.then(() => delay(1000))
209209
.then(() => agentControls.getSpans())
210210
.then(spans => expect(spans).to.be.empty));
211211

212212
it('must propagate suppression downstream for publish', () =>
213213
publisherControls
214214
.publish('Ohai!', { 'X-INSTANA-L': 0 })
215-
.then(() => delay(500))
215+
.then(() => delay(1000))
216216
.then(() => agentControls.getSpans())
217217
.then(spans => expect(spans).to.be.empty));
218218
});
@@ -266,7 +266,8 @@ module.exports = function (name, version, isLatest) {
266266
span => expect(span.n).to.equal('node.http.client'),
267267
span => expect(span.t).to.equal(parentSpan.t),
268268
span => expect(span.p).to.equal(parentSpan.s),
269-
span => expect(span.k).to.equal(constants.EXIT)
269+
span => expect(span.k).to.equal(constants.EXIT),
270+
span => expect(span.data.http.url).to.equal(`http://127.0.0.1:${agentControls.agentPort}/ping`)
270271
]);
271272
}
272273
}

packages/core/src/tracing/instrumentation/messaging/amqp.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ function instrumentedDispatchMessage(ctx, originalDispatchMessage, originalArgs)
185185
return cls.ns.runAndReturn(() => {
186186
if (tracingUtil.readAttribCaseInsensitive(headers, constants.traceLevelHeaderName) === '0') {
187187
cls.setTracingLevel('0');
188+
removeInstanaHeadersFromMessage(originalArgs[1]);
188189
return originalDispatchMessage.apply(ctx, originalArgs);
189190
}
190191

@@ -262,6 +263,7 @@ function instrumentedChannelModelGet(ctx, originalGet, originalArgs) {
262263

263264
if (tracingUtil.readAttribCaseInsensitive(headers, constants.traceLevelHeaderName) === '0') {
264265
cls.setTracingLevel('0');
266+
removeInstanaHeadersFromMessage(result);
265267
span.cancel();
266268
return result;
267269
}
@@ -349,6 +351,7 @@ function instrumentedCallbackModelGet(ctx, originalGet, originalArgs) {
349351

350352
if (tracingUtil.readAttribCaseInsensitive(headers, constants.traceLevelHeaderName) === '0') {
351353
cls.setTracingLevel('0');
354+
removeInstanaHeadersFromMessage(result);
352355
if (originalCallback) {
353356
return originalCallback(err, result);
354357
}

0 commit comments

Comments
 (0)