Commit bdf662f
committed
test: only set INSTANA_TRACING_DISABLE when tracing is actually disabled
ProcessControls was setting INSTANA_TRACING_DISABLE=false for all tests
where tracingEnabled=true (the default). According to the precedence rules
in disable.js, when INSTANA_TRACING_DISABLE is set to 'false', it takes
precedence over INSTANA_TRACING_DISABLE_INSTRUMENTATIONS and
INSTANA_TRACING_DISABLE_GROUPS, preventing granular disable configurations
from working in tests.
This caused logging integration tests to fail when trying to disable
specific instrumentations using INSTANA_TRACING_DISABLE_INSTRUMENTATIONS
or INSTANA_TRACING_DISABLE_GROUPS.
Changed ProcessControls to only set INSTANA_TRACING_DISABLE='true' when
tracingEnabled=false, and not set it at all when tracingEnabled=true,
allowing other disable environment variables to work correctly.1 parent 7059a40 commit bdf662f
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
155 | 154 | | |
156 | 155 | | |
157 | 156 | | |
| |||
164 | 163 | | |
165 | 164 | | |
166 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
167 | 173 | | |
168 | 174 | | |
169 | 175 | | |
| |||
0 commit comments