Skip to content

Commit c1877f2

Browse files
chore: switched to official s390x prebuild image (#2454)
1 parent 1fac564 commit c1877f2

3 files changed

Lines changed: 11 additions & 53 deletions

File tree

packages/autoprofile/CONTRIBUTING.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,20 @@ scripts/custom-dockerfiles/Dockerfile.s390x
6969

7070
### Troubleshooting
7171

72-
If you encounter an error like the following:
72+
1. If you encounter an error like the following:
7373

7474
```
7575
Error: Could not detect abi for version 23.0.0 and runtime node.
7676
```
7777
Solution:
7878

79-
Update [`node-abi`](https://www.npmjs.com/package/node-abi), a sub-dependency of `prebuildify`, to the latest version for Node.js compatibility.
79+
Update [`node-abi`](https://www.npmjs.com/package/node-abi), a sub-dependency of `prebuildify`, to the latest version for Node.js compatibility.
80+
81+
2. **s390x prebuild generation:**
82+
83+
Prebuild generation for the s390x architecture has been verified to work with:
84+
85+
- Rancher Desktop v1.20.1
86+
- Docker v28.3.3
87+
88+
Newer Docker versions may trigger segmentation faults, which can cause the build process to fail. If you encounter this issue, it is recommended to use the versions listed above.

packages/autoprofile/scripts/custom-dockerfiles/Dockerfile.s390x

Lines changed: 0 additions & 47 deletions
This file was deleted.

packages/autoprofile/scripts/prebuilds.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ if (!argv.os || (argv.os && argv.os === 'linux')) {
5151

5252
archs.forEach(image => {
5353
if (image === 'linux-s390x') {
54-
// Since there is no official s390x image available in prebuildify-cross yet,
55-
// we're temporarily using a locally built image. We'll switch to the official image once it's supported.
56-
image = 'abhilashsivan/prebuild-linux-s390x:strip';
57-
5854
childProcess.execSync(
5955
`STRIP=s390x-linux-gnu-strip npx prebuildify-cross --modules ../../node_modules -i ${image} -t ${targets}`,
6056
{

0 commit comments

Comments
 (0)