Skip to content

Commit e221401

Browse files
committed
chore: resolved review comments
1 parent 0ea0448 commit e221401

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

currencies.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,17 @@
186186
"note": "",
187187
"core": false
188188
},
189+
{
190+
"name": "@redis/client",
191+
"policy": "45-days",
192+
"lastSupportedVersion": "",
193+
"latestVersion": "",
194+
"cloudNative": false,
195+
"isBeta": false,
196+
"ignoreUpdates": false,
197+
"note": "",
198+
"core": false
199+
},
189200
{
190201
"name": "amqplib",
191202
"policy": "45-days",

package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
"@opentelemetry/instrumentation": "0.50.0",
112112
"@opentelemetry/sdk-node": "^0.49.1",
113113
"@opentelemetry/sdk-trace-base": "^1.22.0",
114+
"@redis/client": "^5.0.1",
114115
"@redis/client-v4": "npm:@redis/[email protected]",
115116
"@types/chai": "^4.3.0",
116117
"@types/detect-libc": "^1.0.0",

packages/collector/test/tracing/database/redis/test.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,7 @@ const legacyVersion = 'v3';
9797
before(async () => {
9898
controls = new ProcessControls({
9999
useGlobalAgent: true,
100-
appPath:
101-
redisVersion === legacyVersion
102-
? path.join(__dirname, 'legacyApp.js')
103-
: path.join(__dirname, 'app.js'),
100+
appPath: path.join(__dirname, 'app.js'),
104101
env: {
105102
REDIS_VERSION: redisVersion,
106103
REDIS_PKG: redisPkg,
@@ -115,13 +112,6 @@ const legacyVersion = 'v3';
115112
await agentControls.clearReceivedTraceData();
116113
});
117114

118-
before(async () => {
119-
await controls.sendRequest({
120-
method: 'POST',
121-
path: '/clearkeys'
122-
});
123-
});
124-
125115
after(async () => {
126116
await controls.stop();
127117
});

packages/core/src/tracing/instrumentation/database/redis.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ function instrument(redis) {
179179
return creatPoolWrap(poolDescriptor.get.call(this));
180180
}
181181
});
182-
} else if (typeof poolDescriptor.value === 'function') {
182+
} else {
183183
shimmer.wrap(redis, 'createClientPool', creatPoolWrap);
184184
}
185185
}

0 commit comments

Comments
 (0)