fix(core): ensured env vars take precedence over in-code config#2478
Merged
aryamohanan merged 3 commits intofix-config-precedencefrom Apr 10, 2026
Merged
fix(core): ensured env vars take precedence over in-code config#2478aryamohanan merged 3 commits intofix-config-precedencefrom
aryamohanan merged 3 commits intofix-config-precedencefrom
Conversation
Contributor
Author
|
/review |
|
🤖 I've received your review request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aryamohanan
changed the base branch from
fix-config-precedence
to
refactor-config-collector
|
kirrg001
approved these changes
Apr 9, 2026
aryamohanan
force-pushed
the
fix-config-order
branch
from
f6d0e39 to
419a36a
Compare
aryamohanan
changed the base branch from
refactor-config-collector
to
fix-config-precedence
32 tasks
aryamohanan
added a commit
that referenced
this pull request
Apr 10, 2026
BREAKING CHANGE: environment config now overrides in-code configuration. Enforces consistent precedence: env > in-code Previously inconsistent behavior is now fixed. This may impact setups relying on the old precedence. ref https://jsw.ibm.com/browse/INSTA-80965
aryamohanan
added a commit
that referenced
this pull request
Apr 13, 2026
BREAKING CHANGE: environment config now overrides in-code configuration. Enforces consistent precedence: env > in-code Previously inconsistent behavior is now fixed. This may impact setups relying on the old precedence. ref https://jsw.ibm.com/browse/INSTA-80965
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR addressing configuration precedence.
The goal of this change is to ensure the correct order between environment variables and in-code configuration:
env > in-codeCurrently, the precedence between these two sources is mixed. This PR corrects that behavior.
Added missing logging in the configuration file when a config is set.
Scope of This PR
This PR only fixes the precedence between:
Agent configuration precedence will be addressed in separate follow-up PRs.
Coverage: