Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

Commit e239f5b

Browse files
fix: spellcheck and markdown linting
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
1 parent 08e03fe commit e239f5b

5 files changed

Lines changed: 17 additions & 15 deletions

File tree

.github/workflows/functional-gpu-nvidia-t4-x1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ jobs:
115115
- name: Run functional gpu tests with tox
116116
run: |
117117
. venv/bin/activate
118-
tox -e py3-functional-gpu
118+
tox -e functional-gpu
119119
120120
- name: Check disk after tests
121121
run: |

.markdownlint-cli2.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ config:
88
no-duplicate-header: false
99
single-trailing-newline: false
1010
no-duplicate-heading: false
11+
descriptive-link-text: false
1112
globs:
1213
- "**/*.md"
1314
ignores:

.spellcheck-en-custom.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ Aakanksha
55
Backport
66
backported
77
backporting
8-
benchmarking
98
BBH
9+
benchmarking
1010
CHANGELOG
1111
CLI
1212
codebase
@@ -43,9 +43,9 @@ json
4343
jsonl
4444
Langchain's
4545
Leaderboard
46-
lm
4746
LLM
4847
LLMBlock
48+
lm
4949
mbta
5050
MCQ
5151
md
@@ -60,6 +60,7 @@ pre
6060
precomputed
6161
Pregenerated
6262
py
63+
pytest
6364
qa
6465
qna
6566
quantized
@@ -79,10 +80,14 @@ Tesseract
7980
TODO
8081
tokenizer
8182
tokenizers
83+
tox
84+
UI
8285
unchunked
8386
upsampled
8487
UUID
8588
vLLM
89+
VRAM
90+
webhooks
8691
yaml
8792
yamls
8893
Yi

docs/ci.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,16 @@ Functional tests are designed to test SDG components or features in tandem, but
1919
All functional tests currently live in the `tests/functional` directory and are run with [pytest](https://docs.pytest.org/) via [tox](https://tox.wiki/).
2020

2121
We have two types of functional tests - non-GPU and GPU. To run the non-GPU functional tests, you can run `tox -e functional`. To run the GPU functional tests,
22-
you can run `tox -e py3-functional-gpu`.
22+
you can run `tox -e functional-gpu`.
2323

2424
In CI, the non-GPU tests are run with Python 3.10 - 3.12 on Ubuntu and MacOS runners - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/test.yml)
2525

26-
The GPU tests are run with Python 3.11 on CentOS runners with access to a single NVIDIA Telsa T4 GPU with 16GB of vRAM - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/functional-gpu-nvidia-t4-x1.yml)
26+
The GPU tests are run with Python 3.11 on CentOS runners with access to a single NVIDIA Tesla T4 GPU with 16GB of vRAM - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/functional-gpu-nvidia-t4-x1.yml)
2727

2828
## End-to-end (E2E) tests
2929

30-
InstructLab SDG has several end-to-end jobs that run to ensure compatability with the [InstructLab Core](https://github.com/instructlab/instructlab) project.
31-
32-
There is currently a ["small" t-shirt size E2E job](https://github.com/instructlab/sdg/blob/main/.github/workflows/e2e-nvidia-t4-x1.yml) and a
33-
["medium" t-shirt size E2E job](https://github.com/instructlab/sdg/blob/main/.github/workflows/e2e-nvidia-l4-x1.yml).
34-
These jobs runs automatically on all PRs and after commits merge to `main` or release branches. They depend upon the successful completion of any linting type jobs.
35-
36-
There is also a ["large" t-shirt size E2E job](https://github.com/instructlab/sdg/blob/main/.github/workflows/e2e-nvidia-l40s-x4.yml) that can be
37-
[triggered manually on the actions page](#triggering-an-e2e-job-via-github-web-ui) for the repository.
38-
It also runs automatically against the `main` branch at 4PM UTC every day.
30+
InstructLab SDG has several end-to-end jobs that run to ensure compatibility with the [InstructLab Core](https://github.com/instructlab/instructlab) project.
31+
You can see details about the types of jobs being run in the matrix below.
3932

4033
For more details about the E2E scripts themselves, see [the InstructLab Core documentation](https://github.com/instructlab/instructlab/blob/main/docs/maintainers/ci.md#end-to-end-e2e-tests).
4134

@@ -66,3 +59,6 @@ begin and end so it's easier for those involved in the PR to follow the results.
6659
3. Click on the `Run workflow` button on the right side of the page.
6760
4. Enter a branch name or a PR number in the input field.
6861
5. Click the green `Run workflow` button.
62+
63+
> ![NOTE]
64+
> Only users with "Write" permissions to the repo can run CI jobs manually

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ deps = -r requirements-dev.txt
8383
commands =
8484
{envpython} ./scripts/validate_pipelines.py
8585

86-
[testenv:py3-functional-gpu]
86+
[testenv:functional-gpu]
8787
description = run functional tests that require a GPU
8888
package = wheel
8989
wheel_build_env = pkg

0 commit comments

Comments
 (0)