Commit 3ca1c80
[All] Fix PageView annotation visibility and URL issues
- Remove private modifier from mStudentId/mCourseId in StudentContextFragment so @get:PageViewUrlParam is accessible via reflection
- Remove private modifier from moduleItemId in ModuleProgressionFragment for the same reason
- Use ApiPrefs.fullDomain in EditSyllabusFragment to return a full URL instead of a relative path
Co-authored-by: Akos Hermann <hermannakos@users.noreply.github.com>1 parent 85b59c8 commit 3ca1c80
3 files changed
Lines changed: 5 additions & 4 deletions
File tree
- apps/teacher/src/main/java/com/instructure/teacher
- adapters
- features
- modules/progression
- syllabus/edit
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | | - | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
0 commit comments