Quiz report should use user's preference of CSV

Author: Gao-Jun

app/controllers/quizzes/quiz_reports_controller.rb

@@ -172,7 +172,7 @@ def create
     end
 
     statistics.abort_csv_generation if statistics.csv_generation_failed?
-    statistics.generate_csv_in_background
+    statistics.generate_csv_in_background(@current_user)
 
     expose statistics, backward_compatible_includes
   end

app/models/quizzes/quiz_statistics.rb

@@ -64,7 +64,7 @@ def report
   end
 
   # Generates or returns the previously generated CSV version of this report.
-  def generate_csv
+  def generate_csv(user = nil)
     self.csv_attachment ||= begin
       attachment = build_csv_attachment(
         content_type: "text/csv",
@@ -75,15 +75,16 @@ def generate_csv
                           report_type: readable_type
                         }) + ".csv"
       )
-      Attachments::Storage.store_for_attachment(attachment, StringIO.new(report.to_csv))
+      csv_options = user ? CSVWithI18n.csv_i18n_settings(user) : {}
+      Attachments::Storage.store_for_attachment(attachment, StringIO.new(report.to_csv(csv_options)))
       attachment.save!
       attachment
     end
   end
 
   # Queues a job for generating the CSV version of this report unless a job has
   # already been queued, or the attachment had been generated previously.
-  def generate_csv_in_background
+  def generate_csv_in_background(user = nil)
     return if csv_attachment.present? || progress.present?
 
     build_progress
@@ -95,11 +96,11 @@ def generate_csv_in_background
 
     progress.process_job(self, :__process_csv_job, {
                            strand: csv_job_strand_id
-                         })
+                         }, user)
   end
 
-  def __process_csv_job(_progress)
-    generate_csv
+  def __process_csv_job(_progress, user = nil)
+    generate_csv(user)
   end
 
   # Whether the CSV attachment is currently being generated, or is about to be.

app/models/quizzes/quiz_statistics/item_analysis.rb

@@ -68,9 +68,9 @@ def generate(_legacy = true, options = {})
     end
   end
 
-  def to_csv
+  def to_csv(csv_options = {})
     @csv ||=
-      CSV.generate do |csv|
+      CSVWithI18n.generate(**csv_options) do |csv|
         stats = summary_stats_for_quiz
         headers = [
           I18n.t("csv.question.id", "Question Id"),

app/models/quizzes/quiz_statistics/student_analysis.rb

@@ -183,9 +183,9 @@ def attachment_csv(answer)
     end
   end
 
-  def to_csv
+  def to_csv(csv_options = {})
     include_root_accounts = quiz.context.root_account.trust_exists?
-    CSV.generate do |csv|
+    CSVWithI18n.generate(**csv_options) do |csv|
       context = quiz.context
 
       # write columns to csv