allow models of the form make_model("A; B")

[lilymedina]

no causal link between them

[lilymedina]

see WIP PR 165

[macartan]

make_model("A; B") %>% make_data
Error in [.data.frame(types, , exogenous_vars) :
undefined columns selected

[macartan]

seems to have the wrong structure:

Statement: 
[1] "A; B"

DAG: 
  parent children
1   A; B       NA

Need something like :

dag <- data.frame(v = strsplit(statement, ";"), w = NA)

instead of dag <- data.frame(v = statement, w = NA)
in line 59

make_data and other functions probably needs tests though

[till-tietz]

Is there still a desire to make this a feature?

We also run into trouble creating parameters_df for this type of model; see:

m <- CausalQueries::make_model("A; B")
m$parameters_df

  param_names node    gen param_set nodal_type given param_value priors
  <chr>       <chr> <int> <chr>     <chr>      <chr>       <dbl>  <dbl>
1 A; B.0      A; B      1 A; B      0          ""            0.5      1
2 A; B.1      A; B      1 A; B      1          ""            0.5      1

[macartan]

low priority

…

On Fri, Sep 1, 2023 at 9:34 PM Till Tietz ***@***.***> wrote: Is there still a desire to make this a feature? We also run into trouble creating parameters_df for this type of model; see: m <- CausalQueries::make_model("A; B") m$parameters_df param_names node gen param_set nodal_type given param_value priors <chr> <chr> <int> <chr> <chr> <chr> <dbl> <dbl> 1 A; B.0 A; B 1 A; B 0 "" 0.5 1 2 A; B.1 A; B 1 A; B 1 "" 0.5 1 — Reply to this email directly, view it on GitHub <#164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBE57KTDDISYWEP33CG7ELXYI2FBANCNFSM4K7ELS7Q> . You are receiving this because you were assigned.Message ID: ***@***.***>