Skip to content

Commit 779e269

Browse files
committed
Add missing test of override for dest != "passes"
Signed-off-by: John Pennycook <[email protected]>
1 parent bd74524 commit 779e269

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

tests/compilers/test_actions.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,14 @@ def test_extend_match(self):
109109
pattern=r"option_(\d+)",
110110
dest="passes",
111111
)
112+
parser.add_argument(
113+
"--default-override",
114+
action=_ExtendMatchAction,
115+
pattern=r"option_(\d+)",
116+
default=["0"],
117+
dest="override",
118+
override=True,
119+
)
112120

113121
args, _ = parser.parse_known_args(
114122
["--foo=option_1,option_2"],
@@ -125,22 +133,26 @@ def test_extend_match(self):
125133
with self.assertRaises(TypeError):
126134
args, _ = parser.parse_known_args(["--baz=1"], namespace)
127135

128-
# Check that the default pass defined by --qux always exists.
136+
# Check that the default values defined by flags always exists.
129137
# Note that the caller must initialize the default.
138+
namespace.override = ["0"]
130139
namespace._passes = {"--qux": ["0"]}
131140
args, _ = parser.parse_known_args(
132141
[],
133142
namespace,
134143
)
144+
self.assertEqual(args.override, ["0"])
135145
self.assertEqual(args._passes, {"--qux": ["0"]})
136146

137147
# Check that the default pass is overridden by use of --qux.
138148
# Note that the caller must initialize the default.
149+
namespace.override = ["0"]
139150
namespace._passes = {"--qux": ["0"]}
140151
args, _ = parser.parse_known_args(
141-
["--qux=option_1,option_2"],
152+
["--qux=option_1,option_2", "--default-override=option_1"],
142153
namespace,
143154
)
155+
self.assertEqual(args.override, ["1"])
144156
self.assertEqual(args._passes, {"--qux": ["1", "2"]})
145157

146158
namespace._passes = {}
@@ -150,8 +162,6 @@ def test_extend_match(self):
150162
)
151163
self.assertEqual(args._passes, {"--one": ["1", "2"]})
152164

153-
namespace._passes = {}
154-
155165

156166
if __name__ == "__main__":
157167
unittest.main()

0 commit comments

Comments
 (0)