Skip to content

Commit 728a8b6

Browse files
authored
Merge pull request #410 from askervin/58k_e2e_cri_resmgr_extra_args
e2e: add cri_resmgr_extra_args environment variable
2 parents bfcda50 + 8d17140 commit 728a8b6

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

test/e2e/run.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ usage() {
6666
echo " Effective only if \"vm\" does not exist."
6767
echo " See: python3 ${DEMO_LIB_DIR}/numajson2qemuopts.py --help"
6868
echo " cri_resmgr_cfg: configuration file forced to cri-resmgr."
69+
echo " cri_resmgr_extra_args: arguments to be added on cri-resmgr"
70+
echo " command line when launched"
6971
echo " code: Variable that contains test script code to be run"
7072
echo " if SCRIPT is not given."
7173
echo ""
@@ -325,16 +327,17 @@ launch() { # script API
325327
# Usage: launch TARGET
326328
#
327329
# Supported TARGETs:
328-
# cri-resmgr: launch cri-resmgr on VM with configuration file
329-
# in environment variable cri_resmgr_cfg.
330+
# cri-resmgr: launch cri-resmgr on VM. Environment variables:
331+
# cri_resmgr_cfg: configuration filepath (on host)
332+
# cri_resmgr_extra_args: extra arguments on command line
330333
#
331334
# Example:
332335
# cri_resmgr_cfg=/tmp/memtier.cfg launch cri-resmgr
333336
host-command "scp \"$cri_resmgr_cfg\" $VM_SSH_USER@$VM_IP:" || {
334337
command-error "copying \"$cri_resmgr_cfg\" to VM failed"
335338
}
336339
vm-command "cat $(basename "$cri_resmgr_cfg")"
337-
vm-command "cri-resmgr -relay-socket /var/run/cri-resmgr/cri-resmgr.sock -runtime-socket /var/run/containerd/containerd.sock -force-config $(basename "$cri_resmgr_cfg") >cri-resmgr.output.txt 2>&1 &"
340+
vm-command "cri-resmgr -relay-socket /var/run/cri-resmgr/cri-resmgr.sock -runtime-socket /var/run/containerd/containerd.sock -force-config $(basename "$cri_resmgr_cfg") $cri_resmgr_extra_args >cri-resmgr.output.txt 2>&1 &"
338341
sleep 2 >/dev/null 2>&1
339342
vm-command "grep 'FATAL ERROR' cri-resmgr.output.txt" >/dev/null 2>&1 && {
340343
command-error "launching cri-resmgr failed with FATAL ERROR"
@@ -630,6 +633,7 @@ mode=$1
630633
user_script_file=$2
631634
vm=${vm-"crirm-test-e2e"}
632635
cri_resmgr_cfg=${cri_resmgr_cfg-"${SCRIPT_DIR}/cri-resmgr-memtier.cfg"}
636+
cri_resmgr_extra_args=${cri_resmgr_extra_args-""}
633637
cleanup=${cleanup-0}
634638
reinstall_cri_resmgr=${reinstall_cri_resmgr-0}
635639
topology=${topology-'[
@@ -673,6 +677,8 @@ if [ "$mode" == "help" ]; then
673677
echo ""
674678
echo "cri_resmgr_cfg=${cri_resmgr_cfg}"
675679
echo ""
680+
echo "cri_resmgr_extra_args=${cri_resmgr_extra_args}"
681+
echo ""
676682
echo -e "code=\"${code}\""
677683
echo ""
678684
echo "The defaults to QOSCLASS.yaml.in variables:"

0 commit comments

Comments
 (0)