pqos: Allocation command (-a option) hangs with invalid core number.

This bug is fixed.

Signed-off-by: Raghavan Kanagaraj <raghavan.kanagaraj@intel.com>

Author: rkanagar

pqos/alloc.c

@@ -966,7 +966,7 @@ fill_core_tab(char *str)
         *p = '\0';
 
         cos = (unsigned)strtouint64(str);
-        n = strlisttotabrealloc(p + 1, &cores, &max_cores_count);
+        n = strlisttotab(p + 1, cores, max_cores_count);
 
         if (n == 0)
                 goto normal_exit;

pqos/main.c

@@ -44,6 +44,7 @@
 #include "profiles.h"
 
 #include <ctype.h> /**< isspace() */
+#include <errno.h>
 #include <fcntl.h>
 #include <getopt.h> /**< getopt_long() */
 #include <limits.h>
@@ -187,8 +188,20 @@ strtouint64_base(const char *s, int default_base)
                 s += 2;
         }
 
+        errno = 0;
         n = strtoull(s, &endptr, base);
 
+        /* Check for various possible errors */
+        if ((errno == ERANGE && n == ULLONG_MAX) || (errno != 0 && n == 0)) {
+                perror("strtoull");
+                exit(EXIT_FAILURE);
+        }
+
+        if (endptr == s) {
+                printf("No digits were found\n");
+                exit(EXIT_FAILURE);
+        }
+
         if (!(*s != '\0' && *endptr == '\0')) {
                 printf("Error converting '%s' to unsigned number!\n", str);
                 exit(EXIT_FAILURE);