Merge pull request #61 from intel/release-26q1

Release 26q1

Author: byako

.github/scripts/coverage_check.sh

@@ -3,8 +3,8 @@ set -euo pipefail
 
 RESULT=$(make "$1" | awk '/total:/ {print ($3+0)}')
 
-if (( $(echo "$RESULT > $2" | bc -l) )); then
-    echo "$1 $RESULT% is above threshold $2%"
+if (( $(echo "$RESULT >= $2" | bc -l) )); then
+    echo "$1 $RESULT% is above or equal to the threshold $2%"
     exit 0
 else
     echo "$1 $RESULT% is below threshold $2%. Add more tests!"

.gitignore

@@ -1,5 +1,6 @@
 /bin/
 /vendor/
+/cmd/kubelet-gaudi-plugin/vendor
 
 # macOS
 .DS_Store

DEV.md

@@ -61,6 +61,35 @@ cp controller-tools/controller-gen code-generator/client-gen $HOME/go/bin
 # ensure it's in the path. You may want to add export to $HOME/.bashrc
 echo $PATH | grep -q $HOME/go/bin || export PATH=$HOME/go/bin:$PATH
 ```
+# Running tests
+
+Since Q1 '26 Gaudi DRA driver uses `gohlml` to retrieve health-related information.
+There is a hardcoded path to the HLML shared library, with `hack/fake_libhlml` implementing
+a stub / mock version of the `gohlml` project `hlml.h` API and flow control support.
+
+When health-related tests call `gohlml` - it should in turn call fake `libhlml`, instead of the real
+one, on the nodes where there is no real Gaudi HW and SW installed (e.g. CI). This means, if the
+tests are run on your development machine - you should either deploy fresh fake `libhlml.so`, or
+run tests in a `gaudi-dra-driver-test-image` container like CI does.
+
+Deploying fake hlml instead of real `libhlml` should allow running tests in VSCode and other IDEs,
+after `ldconfig` is [configured properly](hack/fake_libhlml/README.md).
+
+## Deploying
+```shell
+$ cd hack/fake_libhlml
+$ make clean
+rm -f fake_libhlml.o fake_libhlml.so
+$ make
+gcc -O -Wall -Wextra -Wno-unused-parameter -fPIC -c fake_libhlml.c -o fake_libhlml.o
+gcc -shared -o fake_libhlml.so fake_libhlml.o
+$ sudo cp ./fake_libhlml.so /usr/lib/habanalabs/libhlml.so
+$ cat << EOF | sudo tee /etc/ld.so.conf.d/habanalabs.conf
+/usr/lib/habanalabs/
+EOF
+
+$ sudo ldconfig
+```
 
 ## Running tests in container
 

Dockerfile.device-faker

@@ -1,5 +1,20 @@
-FROM golang:1.24.2@sha256:b51b7beeabe2e2d8438ba4295c59d584049873a480ba0e7b56d80db74b3e3a3a AS build
+# Copyright (c) 2025, Intel Corporation.  All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 ARG LOCAL_LICENSES
+
+FROM golang:1.25.8@sha256:dfae680962532eeea67ab297f1166c2c4e686edb9a8f05f9d02d96fc9191833e AS build
 WORKDIR /build
 COPY . .
 
@@ -11,20 +26,15 @@ fi && \
 cp -r licenses /install_root/ && \
 cp bin/device-faker /install_root/
 
-
-FROM alpine AS template
-COPY --from=build /install_root/device-faker /device-faker
-
-
 RUN mkdir -p /opt/templates && \
-    /device-faker gpu -n && \
+    bin/device-faker gpu -n && \
     mv /tmp/gpu-template-*.json /opt/templates/gpu-template.json && \
-    /device-faker gaudi -n && \
+    bin/device-faker gaudi -n && \
     mv /tmp/gaudi-template-*.json /opt/templates/gaudi-template.json && \
     chmod 644 /opt/templates/*.json
 
 FROM scratch
 LABEL description="Intel Device Faker"
 COPY --from=build /install_root/device-faker /device-faker
-COPY --from=template /opt/templates /opt/templates
+COPY --from=build /opt/templates /opt/templates
 ENTRYPOINT ["/device-faker"]

Dockerfile.gaudi

@@ -12,21 +12,79 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM golang:1.24.2@sha256:b51b7beeabe2e2d8438ba4295c59d584049873a480ba0e7b56d80db74b3e3a3a AS build
+# Get libc and sources from Ubuntu24, build libhlml, repackage hlml sources with shared lib build modifications
+FROM ubuntu:24.04@sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab AS ubuntu
+RUN \
+cat /etc/apt/sources.list.d/ubuntu.sources && \
+sed -i 's/^Types: deb$/Types: deb deb-src/' /etc/apt/sources.list.d/ubuntu.sources && \
+apt-get update && \
+apt-get install -y dpkg-dev cmake build-essential wget bison flex libyaml-dev pkg-config libudev-dev zlib1g-dev && \
+mkdir /tmp/src && \
+cd /tmp/src && \
+apt-get source libc6 coreutils dash && \
+wget https://vault.habana.ai/artifactory/misc/fw-tools-sources/1.23.0/hl-smi-SA.tgz && \
+mv hl-smi-SA.tgz hl-smi-SA.tar.gz && mkdir hl-smi-SA && cd hl-smi-SA && \
+tar -xf ../hl-smi-SA.tar.gz && \
+make 3rd-party && OPT_C='-O2 -DNDEBUG -fPIC -D_FORTIFY_SOURCE=2 -fstack-protector-strong' && \
+OPT_CXX='-O2 -DNDEBUG -fPIC -D_FORTIFY_SOURCE=2 -fstack-protector-strong' && \
+HARDEN_LD='-Wl,-O1,--as-needed,-z,relro,-z,now' && \
+make -C 3rd-parties/extract/pciutils-3.13.0 clean && \
+make -C 3rd-parties/extract/pciutils-3.13.0 SHARED=no HWDB=no CFLAGS="$OPT_C" && \
+make -C 3rd-parties/extract/lm-sensors-3-6-0 clean && \
+make -C 3rd-parties/extract/lm-sensors-3-6-0 CFLAGS="$OPT_C" BUILD_STATIC_LIB=1 && \
+cp -f 3rd-parties/extract/pciutils-3.13.0/lib/libpci.a 3rd-parties/extract/prod/libpci.a && \
+cp -f 3rd-parties/extract/lm-sensors-3-6-0/lib/libsensors.a 3rd-parties/extract/prod/libsensors.a && \
+cmake -S . -B build-shared -DCMAKE_BUILD_TYPE=Release -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_C_FLAGS_RELEASE="$OPT_C" -DCMAKE_CXX_FLAGS_RELEASE="$OPT_CXX" && \
+cmake --build build-shared --target hlml-raw && \
+gcc -shared -O2 $HARDEN_LD -Wl,--whole-archive \
+build-shared/make/hlml/libhlml-raw.a \
+3rd-parties/extract/prod/libsensors.a \
+3rd-parties/extract/prod/libeeprom-util.a \
+3rd-parties/extract/prod/libhl-thunk-static.a \
+3rd-parties/extract/prod/libhl-thunk-err_injection-static.a \
+3rd-parties/extract/prod/libpci.a \
+-Wl,--no-whole-archive -ldl -lm -lz -o libhlml.so
+
+FROM golang:1.25.8@sha256:dfae680962532eeea67ab297f1166c2c4e686edb9a8f05f9d02d96fc9191833e AS build
+
 ARG LOCAL_LICENSES
 WORKDIR /build
 COPY . .
 
+# install libhlml.so from deb for licenses
+RUN \
+curl -fsSL https://vault.habana.ai/artifactory/api/gpg/key/public | gpg --dearmor | tee /etc/apt/trusted.gpg.d/habanalabs.gpg > /dev/null && \
+wget -q -O /etc/apt/sources.list.d/habanalabs_synapseai.list "https://vault.habana.ai/artifactory/gaudi-installer/repos/1.23.0/ubuntu24.04/habanalabs_synapseai.list" > /dev/null && \
+sed -i "s/^deb/deb [trusted=yes]/" /etc/apt/sources.list.d/habanalabs_synapseai.list && \
+apt-get update && \
+apt-get download habanalabs-firmware-tools && \
+dpkg --force-all -i *.deb
+
+# Build Gaudi driver binary, copy original licenses and sources, and put the GPL license to the root of the container image
 RUN make gaudi && \
 mkdir -p /install_root && \
 if [ -z "$LOCAL_LICENSES" ]; then \
-    make licenses; \
+    make gaudi-licenses; \
 fi && \
 cp -r licenses /install_root/ && \
+mkdir /install_root/licenses/habanalabs && \
+cp /usr/share/doc/habanalabs-firmware-tools/* /install_root/licenses/habanalabs/ && \
+cp cmd/kubelet-gaudi-plugin/LICENSE /install_root/LICENSE && \
 cp bin/kubelet-gaudi-plugin /install_root/
 
 FROM scratch
 LABEL description="Intel Gaudi resource driver for Kubernetes"
 
-COPY --from=build /install_root/ /
-CMD ["/kubelet-gaudi-plugin"]
+COPY --from=build /install_root /
+COPY --from=ubuntu /tmp/src/hl-smi-SA/libhlml.so /usr/lib/habanalabs/libhlml.so
+COPY --from=ubuntu /lib/x86_64-linux-gnu/libc.so.6 /lib/x86_64-linux-gnu/libc.so.6
+COPY --from=ubuntu /lib64/ld-linux-x86-64.so.2 /lib64/ld-linux-x86-64.so.2
+COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libm.so.6 /usr/lib/x86_64-linux-gnu/libm.so.6
+COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libdl.so.2 /usr/lib/x86_64-linux-gnu/libdl.so.2
+COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libz.so.1 /usr/lib/x86_64-linux-gnu/libz.so.1
+COPY --from=ubuntu /bin/cat /bin/cat
+COPY --from=ubuntu /bin/sh /bin/sh
+COPY --from=ubuntu /tmp/src/*tar.* /src/
+
+ENV LD_LIBRARY_PATH=/usr/lib/habanalabs:/lib/x86_64-linux-gnu:/lib64:/usr/lib/x86_64-linux-gnu
+ENV PATH=/bin

Dockerfile.gaudi-test

@@ -11,29 +11,36 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-FROM golang:1.24.2@sha256:b51b7beeabe2e2d8438ba4295c59d584049873a480ba0e7b56d80db74b3e3a3a AS go
+
+# 1. Build fake libhlml for Gaudi tests
+FROM golang:1.25.8@sha256:dfae680962532eeea67ab297f1166c2c4e686edb9a8f05f9d02d96fc9191833e AS build
+WORKDIR /build
+COPY . .
+
+RUN \
+wget -c https://vault.habana.ai/artifactory/debian/noble/pool/main/h/habanalabs-firmware-tools/habanalabs-firmware-tools_1.23.0-695_amd64.deb && \
+apt-get update && \
+apt-get install -y --ignore-missing ./habanalabs-firmware-tools_1.23.0-695_amd64.deb && \
+cd hack/fake_libhlml && \
+make clean && make
 
 FROM ubuntu:24.04@sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab AS ubuntu
 ARG UID=1000
 ARG GID=1000
-COPY --from=go --chown=${UID}:${GID} /usr/local/go /home/ubuntu/go
+# add fake hlml shared library for Gaudi tests
+COPY --from=build /build/hack/fake_libhlml/fake_libhlml.so /usr/lib/habanalabs/libhlml.so
+COPY --from=build /build/cmd/kubelet-gaudi-plugin/LICENSE /LICENSE
+COPY --from=build /usr/include/habanalabs/hlml.h /usr/include/habanalabs/hlml.h
+COPY --from=build --chown=${UID}:${GID} /usr/local/go /home/ubuntu/go
 
-# add xpu-smi shared library for GPU tests and other dependencies
 RUN \
 apt-get update && \
-apt-get install -y make gcc wget software-properties-common python3-launchpadlib git yamllint shellcheck bc && \
-add-apt-repository -y ppa:kobuk-team/intel-graphics && \
-apt-get update && \
-apt-get install -y libze-intel-gpu1 libze1 intel-metrics-discovery intel-opencl-icd clinfo intel-gsc && \
-wget -qO /tmp/xpu-smi.deb https://github.com/intel/xpumanager/releases/download/V1.3.1/xpu-smi_1.3.1_20250724.061629.60921e5e_u24.04_amd64.deb && \
-apt-get install -y /tmp/xpu-smi.deb && \
-rm /tmp/xpu-smi.deb && \
-echo 'export PATH=/home/ubuntu/go/bin:$PATH' >> /home/ubuntu/.bashrc && \
-wget -q https://github.com/golangci/golangci-lint/releases/download/v2.7.2/golangci-lint-2.7.2-linux-amd64.tar.gz && \
-tar zxf golangci-lint-2.7.2-linux-amd64.tar.gz --strip-components=1 golangci-lint-2.7.2-linux-amd64/golangci-lint && \
+apt-get install -y make gcc wget git yamllint shellcheck bc && \
+wget -q https://github.com/golangci/golangci-lint/releases/download/v2.11.4/golangci-lint-2.11.4-linux-amd64.tar.gz && \
+tar zxf golangci-lint-2.11.4-linux-amd64.tar.gz --strip-components=1 golangci-lint-2.11.4-linux-amd64/golangci-lint && \
 mv golangci-lint /usr/local/bin/golangci-lint && \
-rm golangci-lint-2.7.2-linux-amd64.tar.gz && \
-unset http_proxy https_proxy no_proxy
+rm golangci-lint-2.11.4-linux-amd64.tar.gz && \
+echo "export PATH=/home/ubuntu/go/bin:$PATH" >> /home/ubuntu/.bashrc
 
 RUN \
 mkdir /github && \

Dockerfile.gpu

@@ -14,15 +14,10 @@
 
 ARG LOCAL_LICENSES
 
-FROM golang:1.24.2@sha256:b51b7beeabe2e2d8438ba4295c59d584049873a480ba0e7b56d80db74b3e3a3a AS build
+FROM golang:1.25.8@sha256:dfae680962532eeea67ab297f1166c2c4e686edb9a8f05f9d02d96fc9191833e AS build
 WORKDIR /build
 COPY . .
 
-# Add xpu-smi shared library
-RUN \
-wget -qO /tmp/xpu-smi.deb https://github.com/intel/xpumanager/releases/download/V1.3.1/xpu-smi_1.3.1_20250724.061629.60921e5e_u24.04_amd64.deb && \
-dpkg -i --ignore-depends=level-zero,intel-gsc,libze-intel-gpu1 /tmp/xpu-smi.deb
-
 # Build GPU DRA driver
 RUN make gpu && \
 mkdir -p /install_root && \
@@ -32,60 +27,9 @@ fi && \
 cp -r licenses /install_root/ && \
 cp bin/kubelet-gpu-plugin /install_root/
 
-# Prepare dependencies
-FROM ubuntu:24.04@sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab AS ubuntu
-COPY --from=build /tmp/xpu-smi.deb /tmp/xpu-smi.deb
-
-RUN \
-sed -i 's/^Types: deb$/Types: deb deb-src/' /etc/apt/sources.list.d/ubuntu.sources && \
-apt-get update && \
-apt-get install -y software-properties-common python3-launchpadlib
-
-RUN \
-add-apt-repository -s -y ppa:kobuk-team/intel-graphics && \
-apt-get update && \
-apt-get install -y libze-intel-gpu1 libze1 intel-metrics-discovery intel-gsc libmetee5 && \
-apt-get install -y /tmp/xpu-smi.deb
-
-RUN \
-mkdir /tmp/src && \
-cd /tmp/src && \
-apt-get source --download-only dash glibc libcap2 libudev1 libstdc++6 libmetee5 && \
-mkdir /licenses && \
-for pkg in dash libc6 intel-gsc libcap2 libudev1 libze1 libigdgmm12 libstdc++6 libze-intel-gpu1 libmetee5; do \
-    mkdir -p /licenses/$pkg; \
-    cp /usr/share/doc/$pkg/copyright /licenses/$pkg/; \
-done && \
-if grep -q /common-licenses/ /licenses/*/copyright; then \
-    cp -r /usr/share/common-licenses/ /licenses/; \
-fi
-
 FROM scratch
 WORKDIR /
 LABEL description="Intel GPU resource driver for Kubernetes"
 
-# /bin/sh is used by xpu-smi library.
 COPY --from=build /install_root /
-COPY --from=build /usr/lib/x86_64-linux-gnu/libxpum.so.1 /usr/lib/x86_64-linux-gnu/libxpum.so.1
-COPY --from=ubuntu /lib/x86_64-linux-gnu/libc.so.6 /lib/x86_64-linux-gnu/libc.so.6
-COPY --from=ubuntu /lib64/ld-linux-x86-64.so.2 /lib64/ld-linux-x86-64.so.2
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libm.so.6 /usr/lib/x86_64-linux-gnu/libm.so.6
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libdl.so.2 /usr/lib/x86_64-linux-gnu/libdl.so.2
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libz.so.1 /usr/lib/x86_64-linux-gnu/libz.so.1
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libze_loader.so.1 /usr/lib/x86_64-linux-gnu/libze_loader.so.1
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libigsc.so.0 /usr/lib/x86_64-linux-gnu/libigsc.so.0
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libudev.so.1 /usr/lib/x86_64-linux-gnu/libudev.so.1
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libcap.so.2 /usr/lib/x86_64-linux-gnu/libcap.so.2
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libstdc++.so.6 /usr/lib/x86_64-linux-gnu/libstdc++.so.6
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libgcc_s.so.1 /usr/lib/x86_64-linux-gnu/libgcc_s.so.1
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libze_intel_gpu.so.1 /usr/lib/x86_64-linux-gnu/libze_intel_gpu.so.1
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libmetee.so.5.0.0 /usr/lib/x86_64-linux-gnu/libmetee.so.5.0.0
-
-COPY --from=ubuntu /lib/x86_64-linux-gnu/libpciaccess.so.0 /lib/x86_64-linux-gnu/libpciaccess.so.0
-COPY --from=ubuntu /lib/x86_64-linux-gnu/libigdgmm.so.12 /lib/x86_64-linux-gnu/libigdgmm.so.12
-COPY --from=ubuntu /usr/lib/x86_64-linux-gnu/libigc.so.2 /usr/lib/x86_64-linux-gnu/libigc.so.2
-
-COPY --from=ubuntu /bin/sh /bin/sh
-COPY --from=ubuntu /licenses /licenses
-COPY --from=ubuntu /tmp/src /src
 CMD ["/kubelet-gpu-plugin"]

Dockerfile.qat

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM golang:1.24.2@sha256:b51b7beeabe2e2d8438ba4295c59d584049873a480ba0e7b56d80db74b3e3a3a AS build
+FROM golang:1.25.8@sha256:dfae680962532eeea67ab297f1166c2c4e686edb9a8f05f9d02d96fc9191833e AS build
 ARG LOCAL_LICENSES
 WORKDIR /build
 COPY . .