[Bug]: VASurfaceAttribDRMFormatModifiers is ignored in vaCreateSurfaces

[anonymix007]

Which component impacted?

No response

Is it regression? Good in old configuration?

None

What happened?

VASurfaceAttribDRMFormatModifiers can be passed to vaCreateSurfaces, but this media driver seems to ignore it. Briefly looking at the code confirms this.

What's the usage scenario when you are seeing the problem?

Playback

What impacted?

No response

Debug Information

No response

Do you want to contribute a patch to fix the issue?

None

[XinfengZhang]

it should not be an issue, createbuffer accept modifier by VADRMPRIMESurfaceDescriptor

[anonymix007]

GStreamer uses VASurfaceAttribDRMFormatModifiers to create a VASurface with a specific modifier: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-bad/gst-libs/gst/va/vasurfaceimage.c#L144

So this is not actually for importing DMA buffers with modifiers, but for actually exporting them with a specific modifier.