test(history): adding more tests with decorators on getters

Author: arnobl

test/command/memento.test.ts test/command/Memento.test.tstest/command/memento.test.ts renamed to test/command/Memento.test.ts

@@ -1,7 +1,20 @@
-import {getModifiableCmdAttributes, isCmdModifiable, modifyCmdAttributes} from "../../../src/interacto";
+import {getModifiableCmdAttributes, isCmdModifiable, Modifiable, modifyCmdAttributes} from "../../src/interacto";
 import {beforeEach, describe, expect, test} from "@jest/globals";
-import type {UndoableCommand} from "../../../src/interacto";
-import {CmdModifiableDouble, CmdModifiableDouble2, CmdModifiableDouble3} from "../StubCmd";
+import type {UndoableCommand} from "../../src/interacto";
+import {CmdModifiableDouble, CmdModifiableDouble2, CmdModifiableDouble3, ExampleUndoableCmd} from "./StubCmd";
+
+class CmdModifiableGet extends ExampleUndoableCmd {
+    public theX = 10;
+
+    @Modifiable
+    public get x(): number {
+        return this.theX;
+    }
+
+    public set x(value: number) {
+        this.theX = value;
+    }
+}
 
 describe("using a modifiable decorator on commands", () => {
     describe("and an undoable command", () => {
@@ -101,6 +114,15 @@ describe("using a modifiable decorator on commands", () => {
             expect(attributes).toStrictEqual({"a": 0, "b": false});
         });
 
+        test("get modifiable properties on getter", () => {
+            const cmd2 = new CmdModifiableGet();
+            const res = modifyCmdAttributes(cmd2, {
+                "x": 42
+            });
+            expect(res).toBeTruthy();
+            expect(cmd2.theX).toBe(42);
+        });
+
         describe("and an undoable command with incorrect usages of Modifiable", () => {
             test("get modifiable properties does not include the ones badly typed", () => {
                 expect(getModifiableCmdAttributes(new CmdModifiableDouble3())).toStrictEqual({});

…ommand/library/ModifiableCommand.test.ts test/command/ModifiableCommand.test.tstest/command/library/ModifiableCommand.test.ts renamed to test/command/ModifiableCommand.test.ts test/command/library/ModifiableCommand.test.ts renamed to test/command/ModifiableCommand.test.ts

@@ -47,6 +47,23 @@ class CmdEditParagraph extends ExampleUndoableCmd {
     }
 }
 
+class CmdEditParagraph2 extends ExampleUndoableCmd {
+    public paragraph: Paragraph;
+
+    public txt: Txt;
+
+    public constructor(para: Paragraph, txt: Txt) {
+        super();
+        this.paragraph = para;
+        this.txt = txt;
+    }
+
+    @Selective
+    public get paragraphId(): number {
+        return this.paragraph.id;
+    }
+}
+
 describe("using a selective command", () => {
     afterEach(() => {
         jest.clearAllMocks();
@@ -225,7 +242,6 @@ describe("using a selective command", () => {
             const res = [...history.getAllSelectiveObjects()];
             expect(res).toHaveLength(1);
             expect(res).toContain(cmd1.key);
-            // expect(res).toContain(cmd2.otherKey);
         });
 
         test("getAllSelectiveObjects works with several keys", () => {
@@ -303,5 +319,13 @@ describe("using a selective command", () => {
             expect(res[1]).toHaveLength(0);
             expect(res[0]).toStrictEqual([[cmd1, 0], [cmd4, 3], [cmd5, 4]]);
         });
+
+        test("getAllSelectiveObjects works with getters", () => {
+            history = new LinearHistoryImpl();
+            history.add(new CmdEditParagraph2(p1, txt));
+            const res = [...history.getAllSelectiveObjects()];
+            expect(res).toHaveLength(1);
+            expect(res[0]).toBe(p1.id);
+        });
     });
 });