From 447318c909074f7295fca8a40ecd233f919ac752 Mon Sep 17 00:00:00 2001 From: Rich Daley Date: Tue, 3 Jul 2018 14:50:36 +0100 Subject: [PATCH] show_everywhere should still work when user excluded --- lib/intercom-rails/script_tag.rb | 1 - spec/auto_include_filter_spec.rb | 9 +++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/intercom-rails/script_tag.rb b/lib/intercom-rails/script_tag.rb index f4a5521..56205ad 100644 --- a/lib/intercom-rails/script_tag.rb +++ b/lib/intercom-rails/script_tag.rb @@ -35,7 +35,6 @@ def initialize(options = {}) end def valid? - return false if user_details[:excluded_user] == true valid = user_details[:app_id].present? unless @show_everywhere valid = valid && (user_details[:user_id] || user_details[:email]).present? diff --git a/spec/auto_include_filter_spec.rb b/spec/auto_include_filter_spec.rb index eda6537..125b213 100644 --- a/spec/auto_include_filter_spec.rb +++ b/spec/auto_include_filter_spec.rb @@ -142,6 +142,15 @@ def current_user IntercomRails.config.include_for_logged_out_users = true IntercomRails.config.user.exclude_if = Proc.new {|user| user.email.start_with?('ciaran')} get :with_current_user_method + expect(response.body).to include('