Skip to content

[Bug] Revenue share generator accesability, part 2 #193

@DarianM

Description

@DarianM

Description

The ShareInput component in the revshare feature needs accessibility improvements.
While the component was made responsive, it lost some of the accessibility benefits that were present in the original table structure.

Affected component

Revenue Share

Accessibility Issues

  • No table semantics: The data is tabular but doesn't use proper table structure
  • Missing column headers: Screen readers can't associate data with column headers
  • No row/cell relationships: Data relationships are not clear to assistive technology
  • Input labels: Input fields may not have proper labels or descriptions
  • Error announcements: Validation errors may not be announced properly

Files

  • frontend/app/components/redesign/components/revshare/ShareInput.tsx

Proposed Solutions (suggestion only!!)

Enhance Current Structure

  • Add role=\"table\", role=\"row\", role=\"columnheader\", role=\"cell\" attributes
  • Use aria-labelledby to associate cells with column headers
  • Add proper labels for all input fields
  • Implement aria-live regions for error announcements
  • Add aria-describedby for validation messages

Acceptance Criteria

  • Screen readers can navigate and understand the data structure
  • All input fields have proper accessible names
  • Column headers are associated with their data
  • Validation errors are announced to screen readers
  • Keyboard navigation works smoothly
  • Component maintains responsive design

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions