feat: add STREAM connection id in cache key for KYC response, remove unused env vars

Author: sanducb

packages/backend/src/config/app.ts

@@ -203,8 +203,6 @@ export const Config = {
     'SEND_TENANT_WEBHOOKS_TO_OPERATOR',
     false
   ),
-  // TODO Maybe rename?
-  enableKycAseDecision: envBool('ENABLE_KYC_ASE_DECISION', false),
   kycAseDecisionUrl: process.env.KYC_ASE_DECISION_URL,
   kycDecisionMaxWaitMs: envInt('KYC_DECISION_MAX_WAIT_MS', 1500),
   kycDecisionSafetyMarginMs: envInt('KYC_DECISION_SAFETY_MARGIN_MS', 100)

packages/backend/src/payment-method/ilp/connector/core/middleware/kyc-decision.ts

@@ -1,4 +1,4 @@
-import { Errors, IlpErrorCode } from 'ilp-packet'
+import { Errors } from 'ilp-packet'
 import { ILPContext, ILPMiddleware } from '../rafiki'
 import { StreamState } from './stream-address'
 
@@ -9,22 +9,14 @@ export function createKycDecisionMiddleware(): ILPMiddleware {
   ): Promise<void> => {
     const { config, logger, redis } = ctx.services
 
-    // TODO This might not be needed? We should be able to just check the state.hasAdditionalData
-    // if (!config.enableKycAseDecision) {
-    //   await next()
-    //   return
-    // }
-
-    logger.info('KYC Decision Middleware, has additional data: ' + ctx.state.hasAdditionalData)
-
     if (!ctx.state.streamDestination || !ctx.state.hasAdditionalData) {
       await next()
       return
     }
 
     const incomingPaymentId = ctx.state.streamDestination
-    // TODO Maybe we should have a more `unique` key? Think of packet/stream id!!!
-    const cacheKey = `kyc_decision:${incomingPaymentId}`
+    const connectionId = ctx.state.connectionId ?? 'unknown'
+    const cacheKey = `kyc_decision:${incomingPaymentId}:${connectionId}`
 
     // Bounded polling: wait for decision up to (packet expiry - safetyMs) or maxWaitMs
     const safetyMs = Number.isFinite(config.kycDecisionSafetyMarginMs)
@@ -71,5 +63,3 @@ export function createKycDecisionMiddleware(): ILPMiddleware {
     )
   }
 }
-
-

packages/backend/src/payment-method/ilp/connector/core/middleware/stream-address.ts

@@ -7,6 +7,7 @@ export interface StreamState {
   streamDestination?: string
   streamServer?: StreamServer
   hasAdditionalData?: boolean
+  connectionId?: string
 }
 
 export function createStreamAddressMiddleware(): ILPMiddleware {
@@ -47,7 +48,7 @@ export function createStreamAddressMiddleware(): ILPMiddleware {
         const payload = frames?.length
           ? frames.find((f) => f.streamId === 1)?.data ?? frames[0].data
           : undefined
-        
+
         if (payload && payload.length > 0) {
           ctx.services.logger.info(
             { payload: payload.toString('utf8') },
@@ -56,6 +57,9 @@ export function createStreamAddressMiddleware(): ILPMiddleware {
         }
 
         ctx.state.hasAdditionalData = !!payload?.length
+        if (typeof (replyOrMoney as any).connectionId === 'string') {
+          ctx.state.connectionId = (replyOrMoney as any).connectionId
+        }
         //TODO Here we should store STREAM data payload i.e. db call in webhook events table
       }
     } finally {