Upgrade to go 1.26 (#601)

## Summary
Upgrades the Go toolchain from 1.24.2 to 1.26.0, bumps the CI PostGIS
image from EOL PG 12 to PG 16 to match production, removes a stale
Dockerfile, and carves out an explicit exception for the library's
`sqlite3://:memory:` DSN which Go 1.26's stricter `net/url.Parse` now
rejects.

### Go toolchain bump
- `go.mod` directive bumped to `go 1.26.0`
- `.github/workflows/test.yml`,
`.github/workflows/check-go-generate.yaml`, and all three build matrices
in `.github/workflows/release.yml` (linux, macos-intel, macos-apple) set
to `go-version: '1.26.0'`
- `.claude/CLAUDE.md` project-overview line updated to reflect Go 1.26

### CI PostgreSQL image bump
- `.github/workflows/test.yml` test service image bumped from
`postgis/postgis:12-3.4-alpine` to `postgis/postgis:16-3.4-alpine`.
PostgreSQL 12 reached EOL in Nov 2024; PG 16 more closely matches
production. The library uses no PG 13+ exclusive SQL (no `MERGE`,
`JSON_TABLE`, `ANY_VALUE`, etc.), so the CI-only behavior change should
be minimal. PostGIS pinned at 3.4 to keep scope tight.

### Dockerfile cleanup
- Removed the top-level `Dockerfile`, which had been untouched since
2020 and was pinned to Ubuntu 18.04 (EOL) and `golang-1.12` via a
third-party PPA. It was not referenced anywhere in CI.

### net/url regression in Go 1.26
Go 1.26 tightened `net/url.Parse` and now rejects `sqlite3://:memory:`
because `:memory:` after `//` parses as `host:port` with a non-numeric
port. This broke `TestManager_*` tests in `internal/feedstate/` and any
library consumer using the same in-memory DSN form.

Fix: keep `url.Parse` as the primary mechanism (preserving fragment
handling, scheme case-normalization, and structural validation) and add
an explicit string-equality carve-out for the one known incompatible
form, shared as `tldb.sqliteMemoryDBURL`:
- `tldb/adapter.go` — `newAdapter` short-circuits the sqlite memory DSN
and returns the registered `sqlite3` adapter directly; all other dburls
go through `url.Parse` unchanged
- `tldb/common.go` — `getFvids` returns an empty fvid list for the
sqlite memory DSN and otherwise parses as before; errors from
`url.Parse` continue to propagate

Existing tests in `internal/feedstate/manager_test.go` and
`tldb/sqlite/sqlite_test.go` exercise this DSN end-to-end, so no new
tests were added. The `getFvids` URL-smuggling behavior is preserved in
case external consumers of transitland-lib rely on it.

### Workflow hygiene
- `.github/workflows/check-go-generate.yaml` — bumped
`actions/github-script@v6` to `@v7` for consistency with `release.yml`

## Test plan
- Confirm `go version` reports 1.26.x locally before building
- `go mod tidy` produces no diff
- `go vet ./...` is clean
- `(cd cmd/transitland && go build .)` succeeds
- `go test ./internal/feedstate/... ./tldb/...` passes (previously
failing on 1.26)
- Full test suite passes in CI against PG 16 / PostGIS 3.4
- Verify CI jobs run on 1.26.0: Test Suite, Check Generated Code, and on
a tagged release the linux / macos-intel / macos-apple build jobs

Author: irees

.claude/CLAUDE.md

@@ -6,7 +6,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 `transitland-lib` is a Go library and CLI tool for reading, writing, and processing transit data in GTFS and related formats. It provides CSV/database readers and writers, a transformation pipeline (copier), GTFS validation, a GraphQL/REST web API, and DMFR (Distributed Mobility Feed Registry) support.
 
-**Go 1.24.2** | PostgreSQL/PostGIS | SQLite (requires CGO) | GraphQL (gqlgen) | Cobra CLI
+**Go 1.26** | PostgreSQL/PostGIS | SQLite (requires CGO) | GraphQL (gqlgen) | Cobra CLI
 
 ## Build & Test Commands
 

.github/workflows/check-go-generate.yaml

@@ -21,7 +21,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.24.2'
+          go-version: '1.26.0'
 
       - name: Install protoc
         run: |
@@ -49,7 +49,7 @@ jobs:
           fi
 
       - name: Comment on PR
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         if: steps.check_changes.outputs.has_changes == 'true'
         with:
           script: |
@@ -100,7 +100,7 @@ jobs:
             }
 
       - name: Update success comment
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         if: steps.check_changes.outputs.has_changes != 'true'
         with:
           script: |

.github/workflows/release.yml

@@ -46,7 +46,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: ['1.24.2']
+        go-version: ['1.26.0']
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -69,7 +69,7 @@ jobs:
     runs-on: macos-15-large # macOS on Intel
     strategy:
       matrix:
-        go-version: ['1.24.2']
+        go-version: ['1.26.0']
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -109,7 +109,7 @@ jobs:
     runs-on: macos-15 # macOS on Apple Silicon
     strategy:
       matrix:
-        go-version: ['1.24.2']
+        go-version: ['1.26.0']
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.github/workflows/test.yml

@@ -21,15 +21,15 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest] # , macos-15
-        go-version: ['1.24.2']    
+        go-version: ['1.26.0']
     runs-on: ${{ matrix.os }}
     env:
       TL_TEST_DATABASE_URL: postgres://root:for_testing@localhost:5432/tlv2_test?sslmode=disable
       TL_TEST_SERVER_DATABASE_URL: postgres://root:for_testing@localhost:5432/tlv2_test_server?sslmode=disable
       TL_REDIS_URL: redis://localhost
     services:
       postgres:
-        image: postgis/postgis:12-3.4-alpine
+        image: postgis/postgis:16-3.4-alpine
         ports:
           - 5432:5432
         env:

Dockerfile

@@ -1,6 +1,6 @@
 module github.com/interline-io/transitland-lib
 
-go 1.24.2
+go 1.26.0
 
 require (
 	github.com/99designs/gqlgen v0.17.78

go.mod

@@ -9,17 +9,27 @@ import (
 
 var adapterFactories = map[string]func(string) Adapter{}
 
+// sqliteMemoryDBURL is the sqlite in-memory DSN used throughout this library.
+// Go 1.26 tightened net/url and now rejects it because ":memory:" after the
+// authority marker parses as host:port with a non-numeric port. It is carved
+// out explicitly rather than loosening url.Parse handling in general.
+const sqliteMemoryDBURL = "sqlite3://:memory:"
+
 func RegisterAdapter(name string, fn func(string) Adapter) {
 	adapterFactories[name] = fn
 }
 
 // newAdapter returns a Adapter for the given dburl.
 func newAdapter(dburl string) Adapter {
-	u, err := url.Parse(dburl)
-	if err != nil {
-		return nil
+	scheme := "sqlite3"
+	if dburl != sqliteMemoryDBURL {
+		u, err := url.Parse(dburl)
+		if err != nil {
+			return nil
+		}
+		scheme = u.Scheme
 	}
-	fn, ok := adapterFactories[u.Scheme]
+	fn, ok := adapterFactories[scheme]
 	if !ok {
 		return nil
 	}

tldb/adapter.go

@@ -133,6 +133,10 @@ func check(err error) {
 }
 
 func getFvids(dburl string) ([]int, string, error) {
+	// See adapter.go for why this one DSN form is carved out.
+	if dburl == sqliteMemoryDBURL {
+		return []int{}, dburl, nil
+	}
 	fvids := []int{}
 	u, err := url.Parse(dburl)
 	if err != nil {