Skip to content

Commit 45e67b3

Browse files
pezviIA Jim
andauthored
Support liner notes with dockable slider (#1470)
* Support liner notes with dockable slider - BRnavpos under BRnavMain is now hidden by default - controlFor now accepts overrides for bookreader options - Dockable slider forces display of page left/right controls --------- Co-authored-by: IA Jim <jshelton@archive.org>
1 parent 5a48586 commit 45e67b3

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/BookReader/Navbar/Navbar.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,13 @@ export class Navbar {
3333
this.updateNavIndexThrottled = throttle(this.updateNavIndex.bind(this), 250, false);
3434
}
3535

36-
controlFor(controlName) {
37-
const option = this.br.options.controls[controlName];
36+
/**
37+
* @param {string} controlName
38+
* @param {Object} optionOverrides
39+
*/
40+
controlFor(controlName, optionOverrides = null) {
41+
const brOption = this.br.options.controls[controlName];
42+
const option = Object.assign({},brOption, optionOverrides);
3843
if (!option.visible) { return ''; }
3944
if (option.template) {
4045
return `<li>${option.template(this.br)}</li>`;
@@ -273,8 +278,8 @@ export class Navbar {
273278
<div class="BRnavline"></div>
274279
</div>
275280
</li>
276-
${this.controlFor('bookLeft')}
277-
${this.controlFor('bookRight')}
281+
${this.controlFor('bookLeft', {visible: true})}
282+
${this.controlFor('bookRight', {visible: true})}
278283
</ul>
279284
</nav>
280285
</div>
@@ -286,7 +291,7 @@ export class Navbar {
286291
<p>
287292
<span class="BRcurrentpage"></span>
288293
</p>
289-
<div class="BRnavpos">
294+
<div class="BRnavpos hide">
290295
<div class="BRpager"></div>
291296
<div class="BRnavline"></div>
292297
</div>

0 commit comments

Comments
 (0)