Skip to content

Commit 710e930

Browse files
Merge branch 'master' into master
2 parents 0442620 + 5c571e0 commit 710e930

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+1318
-1279
lines changed

.github/workflows/node.js.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- uses: actions/setup-node@v4
2222
with:
2323
# Keep in sync with netlify.toml
24-
node-version: 20.x
24+
node-version: 24.x
2525
- name: Cache node_modules
2626
uses: actions/cache@v4
2727
id: cache
@@ -32,7 +32,7 @@ jobs:
3232
# we don't use `npm ci` specifically to try to get faster CI flows. So caching
3333
# `node_modules` directly.
3434
path: 'node_modules'
35-
key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
35+
key: ${{ runner.os }}-node-24-${{ hashFiles('package*.json') }}
3636
- if: steps.cache.outputs.cache-hit != 'true'
3737
run: npm install
3838

@@ -43,13 +43,13 @@ jobs:
4343
- uses: actions/checkout@v4
4444
- uses: actions/setup-node@v4
4545
with:
46-
node-version: 20.x
46+
node-version: 24.x
4747
- name: Load node_modules from cache
4848
uses: actions/cache@v4
4949
with:
5050
# Use node_modules from previous jobs
5151
path: 'node_modules'
52-
key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
52+
key: ${{ runner.os }}-node-24-${{ hashFiles('package*.json') }}
5353
- name: Cache BookReader/
5454
uses: actions/cache@v4
5555
id: build-cache
@@ -67,13 +67,13 @@ jobs:
6767
- uses: actions/checkout@v4
6868
- uses: actions/setup-node@v4
6969
with:
70-
node-version: 20.x
70+
node-version: 24.x
7171
- name: Load node_modules from cache
7272
uses: actions/cache@v4
7373
with:
7474
# Use node_modules from previous jobs
7575
path: 'node_modules'
76-
key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
76+
key: ${{ runner.os }}-node-24-${{ hashFiles('package*.json') }}
7777
- run: npm run lint
7878
- run: npm run test
7979
- uses: codecov/codecov-action@v4
@@ -87,13 +87,13 @@ jobs:
8787
- uses: actions/checkout@v4
8888
- uses: actions/setup-node@v4
8989
with:
90-
node-version: 20.x
90+
node-version: 24.x
9191
- name: Load node_modules from cache
9292
uses: actions/cache@v4
9393
with:
9494
# Use node_modules from previous jobs
9595
path: 'node_modules'
96-
key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
96+
key: ${{ runner.os }}-node-24-${{ hashFiles('package*.json') }}
9797
- name: Load BookReader/ from cache
9898
uses: actions/cache@v4
9999
with:

.github/workflows/npm-publish.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99

1010
permissions:
1111
contents: read
12+
id-token: write
1213

1314
jobs:
1415
publish-npm:
@@ -17,10 +18,8 @@ jobs:
1718
- uses: actions/checkout@v4
1819
- uses: actions/setup-node@v4
1920
with:
20-
node-version: 20
21+
node-version: 24
2122
registry-url: https://registry.npmjs.org/
2223
- run: npm ci
2324
- run: npm run build
2425
- run: npm publish --tag next
25-
env:
26-
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
BookReader/
2-
BookReaderDev
1+
/BookReader/
2+
/BookReaderDev/
33
node_modules/
44
.DS_Store
55
coverage*/

BookReaderDemo/IADemoBr.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,9 @@ window.initializeBookReader = initializeBookReader;
9595
const showLCP = document.querySelector('#show-lcp');
9696
showLCP.addEventListener('click', async () => {
9797
const iaBr = document.querySelector('ia-bookreader');
98-
const bookNav = iaBr.shadowRoot.querySelector('book-navigator');
99-
100-
bookNav.downloadableTypes = downloadListWithLCP;
101-
102-
bookNav.updateMenuContents();
103-
await bookNav.updateComplete;
98+
iaBr.downloadableTypes = downloadListWithLCP;
99+
iaBr.updateMenuContents();
100+
await iaBr.updateComplete;
104101
});
105102

106103
const multiVolume = document.querySelector('#multi-volume');

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
1+
# 5.0.0-106
2+
- Fix: Slider in 2up left/right only jumping one page @cdrini
3+
4+
# 5.0.0-105
5+
- Fix: Translation layer briefly appearing too large on Chrome @schu96
6+
- Feature: Various accessibility improvements @cdrini
7+
- NVDA reading of text layer
8+
- Labelling of toggle buttons to match state
9+
- Correct aria-labelling of slider
10+
- Fix keyboard handling in slider
11+
12+
# 5.0.0-104
13+
- Dev: Update to node 24 + tweak publish flow @cdrini
14+
15+
# 5.0.0-103
16+
- Fix: Improve accessibility of side panel @cdrini
17+
- Fix: BookReader usage with liner notes @pezvi
18+
119
# 5.0.0-102
220
- Feature: Add dockable slider for mobile @pezvi
321
- Feature: Improve accessibility of search inside panel @cdrini

netlify.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[build.environment]
22
# Keep in sync with CI in .github/workflows/node.js.yml
3-
NODE_VERSION = "20"
3+
NODE_VERSION = "24"
44

55
[[headers]]
66
# Define which paths this specific [[headers]] block will cover.

0 commit comments

Comments
 (0)