Skip to content

Prevent duplicate custom element registration #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deepmalya1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent duplicate custom element registration #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ia-bookreader/downloads/downloads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,6 @@ export class IABookDownloads extends LitElement {
return [buttonStyles, mainCss];
}
}
customElements.define('ia-book-downloads', IABookDownloads);
if (!customElements.get('ia-book-downloads')) {
customElements.define('ia-book-downloads', IABookDownloads);
}
4 changes: 3 additions & 1 deletion src/ia-bookreader/ia-bookreader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,4 +663,6 @@ export class IaBookReader extends LitElement {
}
}

window.customElements.define("ia-bookreader", IaBookReader);
if (!customElements.get('ia-bookreader')) {
window.customElements.define("ia-bookreader", IaBookReader);
}
4 changes: 3 additions & 1 deletion src/ia-bookreader/visual-adjustments/visual-adjustments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,6 @@ export class IABookVisualAdjustments extends LitElement {
return [sharedStyles, main];
}
}
customElements.define('ia-book-visual-adjustments', IABookVisualAdjustments);
if (!customElements.get('ia-book-visual-adjustments')) {
customElements.define('ia-book-visual-adjustments', IABookVisualAdjustments);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/bookmark-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,6 @@ export default class BookmarkButton extends LitElement {
}
}

customElements.define('bookmark-button', BookmarkButton);
if (!customElements.get('bookmark-button')) {
customElements.define('bookmark-button', BookmarkButton);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/bookmark-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,6 @@ export class IABookmarkEdit extends LitElement {
return [buttonCSS, bookmarkColorsCSS, bookmarkEditCSS];
}
}
customElements.define('ia-bookmark-edit', IABookmarkEdit);
if (!customElements.get('ia-bookmark-edit')) {
customElements.define('ia-bookmark-edit', IABookmarkEdit);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/bookmarks-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,4 +281,6 @@ export class IABookmarksList extends LitElement {
return [main, bookmarkColorsCSS];
}
}
customElements.define('ia-bookmarks-list', IABookmarksList);
if (!customElements.get('ia-bookmarks-list')) {
customElements.define('ia-bookmarks-list', IABookmarksList);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/bookmarks-loginCTA.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,6 @@ class BookmarksLogin extends LitElement {
}
}

customElements.define('bookmarks-login', BookmarksLogin);
if (!customElements.get('bookmarks-login')) {
customElements.define('bookmarks-login', BookmarksLogin);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/delete-modal-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,6 @@ export default class DeleteModalActions extends LitElement {
}
}

customElements.define('delete-modal-actions', DeleteModalActions);
if (!customElements.get('delete-modal-actions')) {
customElements.define('delete-modal-actions', DeleteModalActions);
}
4 changes: 3 additions & 1 deletion src/plugins/bookmarks/ia-bookmarks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,4 +546,6 @@ class IABookmarks extends LitElement {
}
}

customElements.define('ia-bookmarks', IABookmarks);
if (!customElements.get('ia-bookmarks')) {
customElements.define('ia-bookmarks', IABookmarks);
}
4 changes: 3 additions & 1 deletion src/plugins/search/search-results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,4 +386,6 @@ export class IABookSearchResults extends LitElement {
return [sharedStyles, buttonCSS, mainCSS];
}
}
customElements.define('ia-book-search-results', IABookSearchResults);
if (!customElements.get('ia-book-search-results')) {
customElements.define('ia-book-search-results', IABookSearchResults);
}