Skip to content

Commit d0ef974

Browse files
committed
chore: log chrome error page, and fix retry attempt comparison
1 parent 85267b8 commit d0ef974

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

brozzler/worker.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ def brozzle_page(
375375
if status_code in [502, 504] or (
376376
page.redirect_url and page.redirect_url.startswith("chrome-error:")
377377
):
378+
self.logger.warning("Chrome Error page encountered", page=page)
378379
raise brozzler.PageConnectionError()
379380
except brozzler.PageInterstitialShown:
380381
page_logger.info("page interstitial shown (http auth)")
@@ -695,7 +696,7 @@ def brozzle_site(self, browser, site):
695696
seconds=retry_delay
696697
)
697698
page.failed_attempts = (page.failed_attempts or 0) + 1
698-
if page.failed_attempts >= brozzler.MAX_PAGE_FAILURES:
699+
if page.failed_attempts > brozzler.MAX_PAGE_FAILURES:
699700
self.logger.info(
700701
'marking page "completed" after several unexpected '
701702
"exceptions attempting to brozzle",

0 commit comments

Comments
 (0)