forked from infogami/infogami
-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
Continuing from #118
I was wondering why do we have two test modules:
testandtests. Runningpytest .seems to be working perfectly well as it will get all the files in bothtestandtestsdirectory and also the subdirectories with the same name. I ran the tests locally withpytest .and all tests are running and passing.
The failing tests are occurring for the doctest. Its failing right at the collection part as its not finding some imports. The list of errors:
ERROR infogami/core/dbupgrade.py - ImportError: cannot import name 'tdb' from 'infogami' (/Users/dhruvmanilawala/projects/infogami/infogami/__init__.py)
ERROR infogami/infobase/bulkupload.py - ImportError: cannot import name 'TYPES' from 'infogami.infobase.infobase' (/Users/dhruvmanilawala/projects/infogami/infogami/infobase/infobase.py)
ERROR infogami/plugins/i18n/code.py - web.webapi.HTTPError: 500 Internal Server Error
ERROR infogami/plugins/links/db.py - ImportError: cannot import name 'tdb' from 'infogami' (/Users/dhruvmanilawala/projects/infogami/infogami/__init__.py)
ERROR infogami/plugins/pages/code.py - ImportError: cannot import name 'tdb' from 'infogami' (/Users/dhruvmanilawala/projects/infogami/infogami/__init__.py)
ERROR infogami/plugins/review/code.py - ImportError: cannot import name 'pickdb' from 'infogami.utils.delegate' (/Users/dhruvmanilawala/projects/infogami/infogami/utils/delegate.py)
ERROR infogami/plugins/review/db.py - ImportError: cannot import name 'pickdb' from 'infogami.utils.delegate' (/Users/dhruvmanilawala/projects/infogami/infogami/utils/delegate.py)
ERROR infogami/plugins/wikitemplates/code.py - web.webapi.HTTPError: 500 Internal Server Error
ERROR migration/migrate-0.4-0.5.py - ModuleNotFoundError: No module named 'migrate-0'
- It seems that
tdbmodule was removed in the commit 1a41e7d and also the moduledbupgradeis not used anywhere in the codebase. - Also, the function
pickdbgot removed in this commit 1144b7b and the constantTYPESgot removed in 010c3e2 migrationmodule should probably be ignored while runningpytest.- It seems that
infogami/plugins/i18n/code.pyandinfogami/plugins/wikitemplates/code.pywill be calling functions on the global scope to setup some things.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels